linux-kernel - Re: [PATCH 00/12] fsi: Convert to bus probe mechanism

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <tkg3ut5prrbur6dqh7elxmu4djqj6dgsymmdzalg5gtqgnn6jn@6pi2fskmnbyb>
Date: Fri, 5 Dec 2025 16:30:19 +0100
From: Uwe Kleine-König <u.kleine-koenig@...libre.com>
To: Eddie James <eajames@...ux.ibm.com>, 
	Andi Shyti <andi.shyti@...nel.org>, Mark Brown <broonie@...nel.org>
Cc: Ninad Palsule <ninad@...ux.ibm.com>, linux-fsi@...ts.ozlabs.org, 
	linux-kernel@...r.kernel.org, linux-i2c@...r.kernel.org, openbmc@...ts.ozlabs.org, 
	linux-spi@...r.kernel.org, Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Subject: Re: [PATCH 00/12] fsi: Convert to bus probe mechanism

Hello,

On Sat, Nov 29, 2025 at 05:57:36PM +0100, Uwe Kleine-König wrote:
> for the quest to drop .probe(), .remove() and .shutdown() from struct
> device_driver, convert the fsi subsystem to make use of the respective
> bus methods. Some cleanups are also included, I noticed those while
> working on the conversion.
> 
> Regarding how to merge this series: There are two drivers touched that
> are not in drivers/fsi, namely drivers/i2c/busses/i2c-fsi.c and
> drivers/spi/spi-fsi.c. The easiest would be to merge this series through
> a single tree because the i2c and spi driver changes depend on some fsi
> core patches and fsi_bus_type can only made private when these are
> applied. I tried to quickly resort the series to only need three steps
> when merged separately, but this wasn't trivially possible, so I hope
> Andi and Mark give their acks to merge their driver changes together
> with the fsi core changes in one go.
> 
> Note this series is only compile tested as I don't have a machine using
> the fsi subsystem. 
> 
> All the calls to get_device() I found in these drivers look a bit
> suspicious and I think there are some issues with lifetime tracking. But
> I didn't try to address these, so I'm just mentioning that here.

While working on more such patches (for other subsystems) I found a
problem in this patch set. Please don't apply it yet, I will prepare a
v2 (and then also explain the things that need to be done).

Thanks
Uwe

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)