linux-kernel - Re: [PATCH] bpftool: Fix build with OpenSSL versions older than 3.0

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20251205153225.GQ724103@e132581.arm.com>
Date: Fri, 5 Dec 2025 15:32:25 +0000
From: Leo Yan <leo.yan@....com>
To: Quentin Monnet <qmo@...nel.org>
Cc: Alexei Starovoitov <ast@...nel.org>,
	Daniel Borkmann <daniel@...earbox.net>,
	Andrii Nakryiko <andrii@...nel.org>,
	Martin KaFai Lau <martin.lau@...ux.dev>,
	Eduard Zingerman <eddyz87@...il.com>, Song Liu <song@...nel.org>,
	Yonghong Song <yonghong.song@...ux.dev>,
	John Fastabend <john.fastabend@...il.com>,
	KP Singh <kpsingh@...nel.org>, Stanislav Fomichev <sdf@...ichev.me>,
	Hao Luo <haoluo@...gle.com>, Jiri Olsa <jolsa@...nel.org>,
	bpf@...r.kernel.org, linux-perf-users@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	Alan Maguire <alan.maguire@...cle.com>
Subject: Re: [PATCH] bpftool: Fix build with OpenSSL versions older than 3.0

On Fri, Dec 05, 2025 at 03:06:33PM +0000, Quentin Monnet wrote:
> On 05/12/2025 14:55, Leo Yan wrote:
> > ERR_get_error_all() exists only in OpenSSL 3.0 and later. Older versions
> > lack this API, causing build failure:
> > 
> >   sign.c: In function 'display_openssl_errors':
> >   sign.c:40:21: warning: implicit declaration of function 'ERR_get_error_all'; did you mean 'ERR_get_error_line'? [-Wimplicit-function-declaration]
> >      40 |         while ((e = ERR_get_error_all(&file, &line, NULL, &data, &flags))) {
> >         |                     ^~~~~~~~~~~~~~~~~
> >         |                     ERR_get_error_line
> >   LINK    /tmp/build/perf/util/bpf_skel/.tmp/bootstrap/bpftool
> >   /usr/lib/gcc/x86_64-alpine-linux-musl/11.2.1/../../../../x86_64-alpine-linux-musl/bin/ld: /tmp/build/perf/util/bpf_skel/.tmp/bootstrap/sign.o: in function `display_openssl_errors.constprop.0':
> >   sign.c:(.text+0x59): undefined reference to `ERR_get_error_all'
> >   collect2: error: ld returned 1 exit status
> > 
> > Use the deprecated ERR_get_error_line_data() for OpenSSL < 3.0, and keep
> > using ERR_get_error_all() when available.
> > 
> > Fixes: 40863f4d6ef2 ("bpftool: Add support for signing BPF programs")
> > Signed-off-by: Leo Yan <leo.yan@....com>
> > ---
> >  tools/bpf/bpftool/sign.c | 4 ++++
> >  1 file changed, 4 insertions(+)
> > 
> > diff --git a/tools/bpf/bpftool/sign.c b/tools/bpf/bpftool/sign.c
> > index b34f74d210e9..c98edd6d1dde 100644
> > --- a/tools/bpf/bpftool/sign.c
> > +++ b/tools/bpf/bpftool/sign.c
> > @@ -37,7 +37,11 @@ static void display_openssl_errors(int l)
> >  	int flags;
> >  	int line;
> >  
> > +#if OPENSSL_VERSION_MAJOR >= 3
> >  	while ((e = ERR_get_error_all(&file, &line, NULL, &data, &flags))) {
> > +#else
> > +	while ((e = ERR_get_error_line_data(&file, &line, &data, &flags))) {
> > +#endif
> >  		ERR_error_string_n(e, buf, sizeof(buf));
> >  		if (data && (flags & ERR_TXT_STRING)) {
> >  			p_err("OpenSSL %s: %s:%d: %s", buf, file, line, data);
> 
> 
> Thanks, but this should be addressed in bpf-next already, see commit
> 90ae54b4c7ec ("bpftool: Allow bpftool to build with openssl < 3")

Thanks for the info.  I suspect someone has fixed it so I did not find
it on the perf mailing list (I should search bpf ML).  Please ignore
this one.

Leo