linux-kernel - Re: [PATCH][next] RDMA/rxe: Avoid -Wflex-array-member-not-at-end warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2191ee0f-a528-4187-ae5b-5aba18741701@linux.dev>
Date: Fri, 5 Dec 2025 20:41:58 -0800
From: Zhu Yanjun <yanjun.zhu@...ux.dev>
To: Jason Gunthorpe <jgg@...dia.com>
Cc: "Gustavo A. R. Silva" <gustavoars@...nel.org>,
 Zhu Yanjun <zyjzyj2000@...il.com>, Leon Romanovsky <leon@...nel.org>,
 linux-rdma@...r.kernel.org, linux-kernel@...r.kernel.org,
 linux-hardening@...r.kernel.org
Subject: Re: [PATCH][next] RDMA/rxe: Avoid -Wflex-array-member-not-at-end
 warnings



在 2025/12/4 9:48, yanjun.zhu 写道:
> On 12/4/25 5:05 AM, Jason Gunthorpe wrote:
>> On Wed, Dec 03, 2025 at 09:08:45PM -0800, Zhu Yanjun wrote:
>>>>        unsigned int        res_head;
>>>>        unsigned int        res_tail;
>>>>        struct resp_res        *res;
>>>> +
>>>> +    /* SRQ only. srq_wqe.dma.sge is a flex array */
>>>> +    struct rxe_recv_wqe srq_wqe;
>>>
>>> drivers/infiniband/sw/rxe/rxe_resp.c: In function get_srq_wqe:
>>> drivers/infiniband/sw/rxe/rxe_resp.c:289:41: error: struct 
>>> rxe_recv_wqe has
>>> no member named wqe
>>>    289 |         qp->resp.wqe = &qp->resp.srq_wqe.wqe;
>>>        |                                         ^
>>
>> I didn't try to fix all the typos, you will need to do that.
> 
> Exactly. I will fix this problem. This weekend, I will send out an 
> official commit.
Hi, Jason

The followings are based on your commits and Leon's commits. And it can 
pass the rdma-core tests.

I am not sure if this commit is good or not.


diff --git a/drivers/infiniband/sw/rxe/rxe_verbs.c 
b/drivers/infiniband/sw/rxe/rxe_verbs.c
index 38d8c408320f..189eaa59a5fb 100644
--- a/drivers/infiniband/sw/rxe/rxe_verbs.c
+++ b/drivers/infiniband/sw/rxe/rxe_verbs.c
@@ -1524,7 +1524,8 @@ static const struct ib_device_ops rxe_dev_ops = {
         INIT_RDMA_OBJ_SIZE(ib_ah, rxe_ah, ibah),
         INIT_RDMA_OBJ_SIZE(ib_cq, rxe_cq, ibcq),
         INIT_RDMA_OBJ_SIZE(ib_pd, rxe_pd, ibpd),
-       INIT_RDMA_OBJ_SIZE(ib_qp, rxe_qp, ibqp),
+       /* For resp.srq_wqe.dma.sge */
+       INIT_RDMA_OBJ_SIZE(ib_qp, rxe_qp, ibqp) + 
RXE_MAX_SGE*sizeof(struct ib_sge),
         INIT_RDMA_OBJ_SIZE(ib_srq, rxe_srq, ibsrq),
         INIT_RDMA_OBJ_SIZE(ib_ucontext, rxe_ucontext, ibuc),
         INIT_RDMA_OBJ_SIZE(ib_mw, rxe_mw, ibmw),
diff --git a/drivers/infiniband/sw/rxe/rxe_verbs.h 
b/drivers/infiniband/sw/rxe/rxe_verbs.h
index fd48075810dd..8c17f5f4e318 100644
--- a/drivers/infiniband/sw/rxe/rxe_verbs.h
+++ b/drivers/infiniband/sw/rxe/rxe_verbs.h
@@ -219,12 +219,6 @@ struct rxe_resp_info {
         u32                     rkey;
         u32                     length;

-       /* SRQ only */
-       struct {
-               struct rxe_recv_wqe     wqe;
-               struct ib_sge           sge[RXE_MAX_SGE];
-       } srq_wqe;
-
         /* Responder resources. It's a circular list where the oldest
          * resource is dropped first.
          */
@@ -232,6 +226,12 @@ struct rxe_resp_info {
         unsigned int            res_head;
         unsigned int            res_tail;
         struct resp_res         *res;
+
+       /* SRQ only. srq_wqe.dma.sge is a flex array */
+       struct {
+               struct rxe_recv_wqe     wqe;
+               struct ib_sge           sge[RXE_MAX_SGE];
+       } srq_wqe;
  };

  struct rxe_qp {
@@ -269,7 +269,6 @@ struct rxe_qp {

         struct rxe_req_info     req;
         struct rxe_comp_info    comp;
-       struct rxe_resp_info    resp;

         atomic_t                ssn;
         atomic_t                skb_out;
@@ -289,6 +288,7 @@ struct rxe_qp {
         spinlock_t              state_lock; /* guard requester and 
completer */

         struct execute_work     cleanup_work;
+       struct rxe_resp_info    resp;
  };

  enum {

Yanjun.Zhu

> 
> Yanjun.Zhu
> 
>>
>> Jason
> 

-- 
Best Regards,
Yanjun.Zhu