linux-kernel - Re: [PATCH 1/2] x86/resctrl: Add missing resctrl initialization for Hygon

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e2303ded-39dc-4441-afab-39bcdecf8e02@open-hieco.net>
Date: Sat, 6 Dec 2025 18:47:40 +0800
From: Xiaochen Shen <shenxiaochen@...n-hieco.net>
To: Fenghua Yu <fenghuay@...dia.com>, tony.luck@...el.com,
 reinette.chatre@...el.com, bp@...en8.de
Cc: babu.moger@....com, james.morse@....com, Dave.Martin@....com,
 x86@...nel.org, linux-kernel@...r.kernel.org, shenxiaochen@...n-hieco.net
Subject: Re: [PATCH 1/2] x86/resctrl: Add missing resctrl initialization for
 Hygon

Hi Fenghua,

Thank you very much for code review!

On 12/6/2025 11:30 AM, Fenghua Yu wrote:
>> Add the missing AMD/Hygon common initialization to ensure proper
>> Platform QoS functionality on Hygon CPUs.
>>
>> Fixes: d8df126349da ("x86/cpu/hygon: Add missing resctrl_cpu_detect() in bsp_init helper")
> 
> This commit triggers the issue on Hygon. You may keep this fix.
> 

Sure. Thank you!


>> Fixes: 923f3a2b48bd ("x86/resctrl: Query LLC monitoring properties once during boot")
> This commit just calls resctrl_cpu_detect() on AMD and Intel. The commit itself doesn't have an issue. Remove this Fixes?
> 

Yes, you are correct. I will remove this Fixes: tag as you suggested.
Thank you!


>> Cc: stable@...r.kernel.org
> Thanks.
> 
> -Fenghua


Best regards,
Xiaochen Shen