linux-kernel - Re: [PATCH v3 1/4] clk: microchip: core: remove duplicate determine_rate on pic32_sclk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <0ce7cb31-b8ed-483d-9260-59da9841049c@tuxon.dev>
Date: Sat, 6 Dec 2025 16:30:27 +0200
From: Claudiu Beznea <claudiu.beznea@...on.dev>
To: Brian Masney <bmasney@...hat.com>,
 Michael Turquette <mturquette@...libre.com>, Stephen Boyd
 <sboyd@...nel.org>, Maxime Ripard <mripard@...nel.org>,
 Conor Dooley <conor@...nel.org>, Dan Carpenter <dan.carpenter@...aro.org>
Cc: linux-clk@...r.kernel.org, linux-kernel@...r.kernel.org,
 kernel test robot <lkp@...el.com>
Subject: Re: [PATCH v3 1/4] clk: microchip: core: remove duplicate
 determine_rate on pic32_sclk_ops



On 12/5/25 21:46, Brian Masney wrote:
> pic32_sclk_ops previously had a sclk_round_rate() member, and this was
> recently converted over to sclk_determine_rate() with the help of a
> Coccinelle semantic patch. pic32_sclk_ops now has two conflicting
> determine_rate ops members.
> 
> Prior to the conversion, pic32_sclk_ops already had a determine_rate
> member that points to __clk_mux_determine_rate(). When both the
> round_rate() and determine_rate() ops are defined, the clk core only
> uses the determine_rate() op. Let's go ahead and drop the recently
> converted sclk_determine_rate() to match the previous functionality
> prior to the conversion.
> 
> Fixes: e9f039c08cdc ("clk: microchip: core: convert from round_rate() to determine_rate()")
> Reported-by: kernel test robot <lkp@...el.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202511222115.uvHrP95A-lkp@intel.com/
> Signed-off-by: Brian Masney <bmasney@...hat.com>
Reviewed-by: Claudiu Beznea <claudiu.beznea@...on.dev>