linux-kernel - Re: [PATCH] mac80211_hwsim: fix divide error in mac80211_hwsim_link_info

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6cc422bb9525be529c6b0d2d25f9869ca41ec77d.camel@sipsolutions.net>
Date: Sat, 06 Dec 2025 15:56:43 +0100
From: Johannes Berg <johannes@...solutions.net>
To: Deepakkumar Karn <dkarn@...hat.com>
Cc: linux-kernel@...r.kernel.org, linux-wireless@...r.kernel.org, 
	shaul.triebitz@...el.com, 
	syzbot+5bb5f06f99924ea0cf86@...kaller.appspotmail.com
Subject: Re: [PATCH] mac80211_hwsim: fix divide error in
 mac80211_hwsim_link_info_changed

On Sat, 2025-12-06 at 04:33 +0530, Deepakkumar Karn wrote:
> On Fri, 05 Dec 2025 18:39:49 +0100, Johannes Berg wrote:
> > Seems like we should not let userspace do that, to protect all other
> > drivers too, not just hwsim.
>  
> As suggested, we should provide a zero-value division check for other 
> drivers as well. I will investigate other places where divide errors can 
> occur due to edge cases.

What, no no.

> Please let me know if you meant something different. In the meantime,
> I will analyze other drivers for similar cases.

I did. My point is we shouldn't _have_ to check any drivers for this at
all, it's nonsense and higher layers (here cfg80211) should reject it.

johannes