linux-kernel - Re: [PATCH] gpiolib: acpi: Add quirk for Dell Precision 7780

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aTRTkYMuA279jXD3@smile.fi.intel.com>
Date: Sat, 6 Dec 2025 18:02:25 +0200
From: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To: Askar Safin <safinaskar@...il.com>
Cc: Mika Westerberg <westeri@...nel.org>,
	Linus Walleij <linus.walleij@...aro.org>,
	Bartosz Golaszewski <brgl@...nel.org>, linux-gpio@...r.kernel.org,
	linux-acpi@...r.kernel.org, linux-kernel@...r.kernel.org,
	regressions@...ts.linux.dev, Dell.Client.Kernel@...l.com,
	Mario Limonciello <superm1@...nel.org>, patches@...ts.linux.dev,
	Askar Safin <safinaskar@...omail.com>, stable@...r.kernel.org
Subject: Re: [PATCH] gpiolib: acpi: Add quirk for Dell Precision 7780

On Fri, Dec 05, 2025 at 10:32:42PM +0000, Askar Safin wrote:
> Dell Precision 7780 often wakes up on its own from suspend. Sometimes
> wake up happens immediately (i. e. within 7 seconds), sometimes it happens
> after, say, 30 minutes.

Thanks for the patch, it looks quite good. See my comments below.

...

> Reported-by: Askar Safin <safinaskar@...omail.com>
> Tested-by: Askar Safin <safinaskar@...il.com>

I believe it's the same person in both cases as the author of the patch.
As Bart said, just drop these tags, it makes little sense to have them.

...

> +		/*
> +		 * Spurious wakeups, likely from touchpad controller
> +		 * Dell Precision 7780
> +		 * Found in BIOS 1.24.1

Not sure if we also want BIOS version, probably it's more important than Board
Name, but okay, we may not know without trying if any other users need the same
quirk or will suffer from it (if BIOS version is different).

> +		 * Found in touchpad firmware, installed by Dell Touchpad Firmware Update Utility version 1160.4196.9, A01
> +		 * ( Dell-Touchpad-Firmware-Update-Utility_VYGNN_WIN64_1160.4196.9_A00.EXE ),
> +		 * released on 11 Jul 2024
> +		 *
> +		 * https://lore.kernel.org/linux-i2c/197ae95ffd8.dc819e60457077.7692120488609091556@zohomail.com/
> +		 */
> +		.matches = {
> +			DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
> +			DMI_MATCH(DMI_PRODUCT_FAMILY, "Precision"),
> +			DMI_MATCH(DMI_PRODUCT_NAME, "Precision 7780"),
> +			DMI_MATCH(DMI_BOARD_NAME, "0C6JVW"),
> +		},
> +		.driver_data = &(struct acpi_gpiolib_dmi_quirk) {
> +			.ignore_wake = "VEN_0488:00@355",
> +		},
> +	},

With tags removed, feel free to add my
Reviewed-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>

Note, it's your responsibility to carry the given tags as long as there were
no significant changes in the patch. That said, I expect to see a v2
without your 2 tags and with mine that I gave above. No code changes for now.

-- 
With Best Regards,
Andy Shevchenko