lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <aTRatkxEqIxL3EEP@smile.fi.intel.com>
Date: Sat, 6 Dec 2025 18:32:54 +0200
From: Andy Shevchenko <andriy.shevchenko@...el.com>
To: Dharanitharan R <dharanitharan725@...il.com>
Cc: Lars-Peter Clausen <lars@...afoo.de>,
	Michael Hennerich <Michael.Hennerich@...log.com>,
	Jonathan Cameron <jic23@...nel.org>,
	David Lechner <dlechner@...libre.com>,
	Nuno Sá <nuno.sa@...log.com>,
	Andy Shevchenko <andy@...nel.org>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	linux-iio@...r.kernel.org, linux-staging@...ts.linux.dev,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v1] staging: iio: frequency: ad9832: replace long/short
 with u32/u16

On Sat, Dec 06, 2025 at 05:48:31AM +0000, Dharanitharan R wrote:
> Cleanup the AD9832 header by explicitly including <linux/types.h> and
> replacing ambiguous integer types with fixed-width kernel types:
> 
> - unsigned long → u32
> - unsigned short → u16
> 
> This improves type clarity and ensures consistent behavior across
> architectures.

I have nothing to add to the Jonathan's review, just shift your focus to
another driver instead. And if see another platform data, kill it. We don't
use platform data approach in a new code.

-- 
With Best Regards,
Andy Shevchenko



Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ