linux-kernel - Re: [PATCH v4 8/8] arm64: dts: qcom: Add support for Pixel 3 and Pixel 3 XL

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <e0be618c-4224-45a4-9cd5-00001510fdec@ixit.cz>
Date: Sat, 6 Dec 2025 18:20:35 +0100
From: David Heidelberg <david@...t.cz>
To: Bjorn Andersson <andersson@...nel.org>
Cc: Konrad Dybcio <konradybcio@...nel.org>, Rob Herring <robh@...nel.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
 <conor+dt@...nel.org>, Sumit Semwal <sumit.semwal@...aro.org>,
 Casey Connolly <casey.connolly@...aro.org>,
 Neil Armstrong <neil.armstrong@...aro.org>,
 Jessica Zhang <jesszhan0024@...il.com>,
 Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>,
 Maxime Ripard <mripard@...nel.org>, Thomas Zimmermann <tzimmermann@...e.de>,
 David Airlie <airlied@...il.com>, Simona Vetter <simona@...ll.ch>,
 Marijn Suijten <marijn.suijten@...ainline.org>,
 Dmitry Baryshkov <lumag@...nel.org>, Vinod Koul <vkoul@...nel.org>,
 phodina@...tonmail.com, linux-arm-msm@...r.kernel.org,
 devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
 phone-devel@...r.kernel.org, dri-devel@...ts.freedesktop.org,
 Amit Pundir <amit.pundir@...aro.org>, Casey Connolly <casey@...nolly.tech>,
 Joel Selvaraj <foss@...lselvaraj.com>
Subject: Re: [PATCH v4 8/8] arm64: dts: qcom: Add support for Pixel 3 and
 Pixel 3 XL



On 06/12/2025 17:56, Bjorn Andersson wrote:
> On Tue, Nov 25, 2025 at 09:29:43PM +0100, David Heidelberg via B4 Relay wrote:
>> From: David Heidelberg <david@...t.cz>
>>
>> This adds initial device tree support for the following phones:
>>
>>   - Google Pixel 3 (blueline)
>>   - Google Pixel 3 XL (crosshatch)
>>
>> Both phone boards use the same identifiers and differ only slightly
>> in their connected peripherals.
>>
>> Supported functionality includes:
>>   - Debug UART
>>   - UFS
>>   - USB-C (peripheral mode)
>>   - Display (Pixel 3 only, and the driver needs improvements)
>>   - GPU
>>   - Bluetooth
>>   - Wi-Fi
>>
>> The rmtfs region is allocated using UIO, making it technically "dynamic."
>>
>> Its address and size can be read from sysfs:
>>
>> $ cat /sys/class/uio/uio0/name
>> /sys/class/uio/uio0/maps/map0/addr
>> 0x00000000f2701000
>>
>> $ cat /sys/class/uio/uio0/maps/map0/size
>> 0x0000000000200000
>>
>> Like the OnePlus 6, the Pixel 3 requires 1 kB of reserved memory on either
>> side of the rmtfs region to work around an XPU bug that would otherwise
>> cause erroneous violations when accessing the rmtfs_mem region.
>>
>> Co-developed-by: Amit Pundir <amit.pundir@...aro.org>
>> Signed-off-by: Amit Pundir <amit.pundir@...aro.org>
>> Co-developed-by: Bjorn Andersson <bjorn.andersson@...aro.org>
>> Signed-off-by: Bjorn Andersson <bjorn.andersson@...aro.org>
> 
> Did I really co-author this patch? Perhaps I contributed parts to it?
> Perhaps I've just forgotten?

The patch and it's parts I used contained your S-off-by, so I added 
Co-developed-by as I assumed parts of it was written by you.

That's hard about seeing patches downstream, as the history is not so clear.

> 
> Either way, I don't think I can say that I certify origin of the whole
> patch.

Should I drop your the Signed-off-by then (and eventually all people who 
didn't worked on the series I sent to upstream)?
> 
> 
> Any parts that I did contribute, would have met the criteria, so you're
> free to use those.

Thanks!

David

> 
> Regards,
> Bjorn
> 
>> Co-developed-by: Casey Connolly <casey@...nolly.tech>
>> Signed-off-by: Casey Connolly <casey@...nolly.tech>
>> Co-developed-by: Joel Selvaraj <foss@...lselvaraj.com>
>> Signed-off-by: Joel Selvaraj <foss@...lselvaraj.com>
>> Co-developed-by: Sumit Semwal <sumit.semwal@...aro.org>
>> Signed-off-by: Sumit Semwal <sumit.semwal@...aro.org>
>> Co-developed-by: Vinod Koul <vkoul@...nel.org>
>> Signed-off-by: Vinod Koul <vkoul@...nel.org>
>> Signed-off-by: David Heidelberg <david@...t.cz>
>> ---
>>   arch/arm64/boot/dts/qcom/Makefile                  |   2 +
>>   .../arm64/boot/dts/qcom/sdm845-google-blueline.dts |  77 +++
>>   arch/arm64/boot/dts/qcom/sdm845-google-common.dtsi | 528 +++++++++++++++++++++
>>   .../boot/dts/qcom/sdm845-google-crosshatch.dts     |  28 ++
>>   4 files changed, 635 insertions(+)
>>