linux-kernel - Re: [PATCH v2] iio: adc: spear_adc: cleans up, update and sorts the existing includes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAHp75Vc3K=w1FukPmPkuhiFDj2JgZpWeiD1b2d++a_mybZH3rg@mail.gmail.com>
Date: Sat, 6 Dec 2025 19:55:15 +0200
From: Andy Shevchenko <andy.shevchenko@...il.com>
To: Rodrigo Gobbi <rodrigo.gobbi.7@...il.com>
Cc: jic23@...nel.org, dlechner@...libre.com, nuno.sa@...log.com, 
	andy@...nel.org, ~lkcamp/patches@...ts.sr.ht, linux-iio@...r.kernel.org, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] iio: adc: spear_adc: cleans up, update and sorts the
 existing includes

On Sat, Dec 6, 2025 at 3:21 PM Rodrigo Gobbi <rodrigo.gobbi.7@...il.com> wrote:
>
> Remove unused includes and add what is being used (IWYU principle) and
> sort the remaining ones.

...

> +#include <linux/array_size.h>
>  #include <linux/bitfield.h>
> +#include <linux/bits.h>
>  #include <linux/clk.h>

> +#include <linux/compiler_types.h>

It's rare that we include this low-level header in the driver's C
code. Usually we do include types.h. Also types.h is missing for uXX
in the code. Also types.h brings NULL definition from stddef.h and we,
for now, consider that it's guaranteed inclusion, so we don't add
stddef.h explicitly in such cases.

>  #include <linux/completion.h>
> +#include <linux/dev_printk.h>
> +#include <linux/err.h>
> +#include <linux/interrupt.h>
> +#include <linux/io.h>
> +#include <linux/math.h>
> +#include <linux/module.h>
> +#include <linux/mod_devicetable.h>
> +#include <linux/mutex.h>

> +#include <linux/of.h>

Jonathan already said about this one.

> +#include <linux/platform_device.h>
> +#include <linux/property.h>


-- 
With Best Regards,
Andy Shevchenko