linux-kernel - Re: [PATCH 4/4] arm64: dts: microchip: add LAN969x support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d98b3069-861c-456d-8637-67e36dc107bb@lunn.ch>
Date: Sat, 6 Dec 2025 19:06:41 +0100
From: Andrew Lunn <andrew@...n.ch>
To: Claudiu Beznea <claudiu.beznea@...on.dev>
Cc: Robert Marko <robert.marko@...tura.hr>, robh@...nel.org,
	krzk+dt@...nel.org, conor+dt@...nel.org, gregkh@...uxfoundation.org,
	nicolas.ferre@...rochip.com, mturquette@...libre.com,
	sboyd@...nel.org, richardcochran@...il.com,
	devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
	linux-usb@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
	linux-clk@...r.kernel.org, daniel.machon@...rochip.com,
	UNGLinuxDriver@...rochip.com, luka.perkov@...tura.hr,
	Horatiu Vultur <horatiu.vultur@...rochip.com>
Subject: Re: [PATCH 4/4] arm64: dts: microchip: add LAN969x support

On Sat, Dec 06, 2025 at 03:53:42PM +0200, Claudiu Beznea wrote:
> > +		port29: port@29 {
> > +			reg = <29>;
> > +			microchip,bandwidth = <1000>;
> > +			phys = <&serdes 11>;
> > +			phy-handle = <&phy3>;
> > +			phy-mode = "rgmii";
> 
> >From chekpatch:
> 
> WARNING: phy-mode "rgmii" without comment -- delays on the PCB should be
> described, otherwise use "rgmii-id"
> #779: FILE: arch/arm64/boot/dts/microchip/lan9696-ev23x71a.dts:750:
> +                       phy-mode = "rgmii";
> 
> > +			rx-internal-delay-ps = <1000>;
> > +			tx-internal-delay-ps = <1000>;
> > +		};

I did a very quick scan of the patch and missed that. It is great that
checkpatch is now commenting about "rgmii".

1ns is very odd. You need a total of 2ns, so where is the rest coming
from? This definitely needs a comment explaining what is going on.

Also, RGMII typically does not need a SERDES, unless there is
something like an SGMII to RGMII converter being used. So is the phys
property needed?

	Andrew