linux-kernel - Re: [PATCH v6 2/2] iio: amplifiers: adl8113: add driver support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aTSWk_p62hJBKCtN@smile.fi.intel.com>
Date: Sat, 6 Dec 2025 22:48:19 +0200
From: Andy Shevchenko <andriy.shevchenko@...el.com>
To: Jonathan Cameron <jic23@...nel.org>
Cc: Antoniu Miclaus <antoniu.miclaus@...log.com>,
	Lars-Peter Clausen <lars@...afoo.de>,
	Michael Hennerich <Michael.Hennerich@...log.com>,
	David Lechner <dlechner@...libre.com>,
	Nuno Sá <nuno.sa@...log.com>,
	Andy Shevchenko <andy@...nel.org>, Rob Herring <robh@...nel.org>,
	Krzysztof Kozlowski <krzk+dt@...nel.org>,
	Conor Dooley <conor+dt@...nel.org>, linux-iio@...r.kernel.org,
	devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v6 2/2] iio: amplifiers: adl8113: add driver support

On Sat, Dec 06, 2025 at 07:03:32PM +0000, Jonathan Cameron wrote:
> On Fri, 5 Dec 2025 16:40:41 +0200
> Antoniu Miclaus <antoniu.miclaus@...log.com> wrote:

...

> > +	/* Always include internal amplifier (14dB) */
> > +	st->gain_configs[i].path = ADL8113_INTERNAL_AMP;
> > +	st->gain_configs[i].gain_db = 14;
> 
> Could do this as something like:

I remember a discussion where it was against this approach due to compiler
warnings or so. However, IIRC, there was slightly different pattern, i.e.

	foo[i].bar = ...
	foo[i++].baz = ...

That said, I have no objection to your proposal, but we need to use it with
a good compile test coverage (clang with `make W=1` for a starter.

OTOH, the original code is robust enough...

> 	st->gain_configs[i++] = (struct adl8113_gain_config) {
> 		.path = ADL8113_INTERNAL_AMP,
> 		.gain_db = 14,
> 	};

...and doesn't require a good understanding of differences between designated
initialisers and compound literals.

> 	st->gain_configs[i++] = (struct adl8113_gain_config) {
> 		.path = ADL8113_INTERNAL_BYPASS,
> 		.gain_db = -2,
> 	};


-- 
With Best Regards,
Andy Shevchenko