linux-kernel - Re: [PATCH] iio: inkern: Use namespaced exports

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20251207140046.56322d6f@jic23-huawei>
Date: Sun, 7 Dec 2025 14:00:46 +0000
From: Jonathan Cameron <jic23@...nel.org>
To: Romain Gantois <romain.gantois@...tlin.com>
Cc: MyungJoo Ham <myungjoo.ham@...sung.com>, Chanwoo Choi
 <cw00.choi@...sung.com>, Guenter Roeck <linux@...ck-us.net>, Peter Rosin
 <peda@...ntia.se>, Nuno Sá <nuno.sa@...log.com>, Andy
 Shevchenko <andy@...nel.org>, Lars-Peter Clausen <lars@...afoo.de>, Michael
 Hennerich <Michael.Hennerich@...log.com>, Mariel Tinaco
 <Mariel.Tinaco@...log.com>, Kevin Tsai <ktsai@...ellamicro.com>, Linus
 Walleij <linus.walleij@...aro.org>, Dmitry Torokhov
 <dmitry.torokhov@...il.com>, Eugen Hristev <eugen.hristev@...aro.org>,
 Vinod Koul <vkoul@...nel.org>, Kishon Vijay Abraham I <kishon@...nel.org>,
 Sebastian Reichel <sre@...nel.org>, Chen-Yu Tsai <wens@...e.org>, Hans de
 Goede <hansg@...nel.org>, Support Opensource
 <support.opensource@...semi.com>, Paul Cercueil <paul@...pouillou.net>,
 Iskren Chernev <me@...ren.info>, Krzysztof Kozlowski <krzk@...nel.org>,
 Marek Szyprowski <m.szyprowski@...sung.com>, Matheus Castello
 <matheus@...tello.eng.br>, Saravanan Sekar <sravanhome@...il.com>, Matthias
 Brugger <matthias.bgg@...il.com>, AngeloGioacchino Del Regno
 <angelogioacchino.delregno@...labora.com>, Casey Connolly
 <casey.connolly@...aro.org>, Pali Rohár <pali@...nel.org>,
 Orson Zhai <orsonzhai@...il.com>, Baolin Wang
 <baolin.wang@...ux.alibaba.com>, Chunyan Zhang <zhang.lyra@...il.com>, Amit
 Kucheria <amitk@...nel.org>, Thara Gopinath <thara.gopinath@...il.com>,
 "Rafael J. Wysocki" <rafael@...nel.org>, Daniel Lezcano
 <daniel.lezcano@...aro.org>, Zhang Rui <rui.zhang@...el.com>, Lukasz Luba
 <lukasz.luba@....com>, Claudiu Beznea <claudiu.beznea.uj@...renesas.com>,
 Liam Girdwood <lgirdwood@...il.com>, Mark Brown <broonie@...nel.org>,
 Jaroslav Kysela <perex@...ex.cz>, Takashi Iwai <tiwai@...e.com>, Sylwester
 Nawrocki <s.nawrocki@...sung.com>, Olivier Moysan
 <olivier.moysan@...s.st.com>, Arnaud Pouliquen
 <arnaud.pouliquen@...s.st.com>, Maxime Coquelin
 <mcoquelin.stm32@...il.com>, Alexandre Torgue
 <alexandre.torgue@...s.st.com>, David Lechner <dlechner@...libre.com>,
 Thomas Petazzoni <thomas.petazzoni@...tlin.com>,
 linux-kernel@...r.kernel.org, linux-hwmon@...r.kernel.org,
 linux-iio@...r.kernel.org, linux-input@...r.kernel.org,
 linux-phy@...ts.infradead.org, linux-pm@...r.kernel.org,
 linux-mips@...r.kernel.org, linux-mediatek@...ts.infradead.org,
 linux-arm-msm@...r.kernel.org, linux-sound@...r.kernel.org,
 linux-stm32@...md-mailman.stormreply.com
Subject: Re: [PATCH] iio: inkern: Use namespaced exports

On Tue, 02 Dec 2025 08:30:58 +0100
Romain Gantois <romain.gantois@...tlin.com> wrote:

> On Monday, 1 December 2025 18:15:54 CET David Lechner wrote:
> > On 12/1/25 4:59 AM, Romain Gantois wrote:  
> > > Use namespaced exports for IIO consumer API functions.
> > > 
> > > Signed-off-by: Romain Gantois <romain.gantois@...tlin.com>
> > > ---  
> > 
> > ...
> >   
> > > diff --git a/drivers/iio/dac/ds4424.c b/drivers/iio/dac/ds4424.c
> > > index a8198ba4f98a..33d6692f46fe 100644
> > > --- a/drivers/iio/dac/ds4424.c
> > > +++ b/drivers/iio/dac/ds4424.c
> > > @@ -14,7 +14,6 @@
> > > 
> > >  #include <linux/iio/iio.h>
> > >  #include <linux/iio/driver.h>
> > >  #include <linux/iio/machine.h>
> > > 
> > > -#include <linux/iio/consumer.h>  
> > 
> > Unrelated change?  
> 
> Indeed, I'll leave that out in v2.

Please spin a precursor patch that makes that change.
That way we can easily check all files either both include that header
and have the namespace enabled, or neither.

I might merge this is a slightly funny way that leave it initially
not meeting that rule so that the precursor isn't in the immutable branch
for other subsystems but lets keep it logical in the patch set!

Jonathan

> 
> > >  #define DS4422_MAX_DAC_CHANNELS		2
> > >  #define DS4424_MAX_DAC_CHANNELS		4
> > > 
> > > @@ -321,3 +320,4 @@ MODULE_AUTHOR("Ismail H. Kose
> > > <ismail.kose@...imintegrated.com>");> 
> > >  MODULE_AUTHOR("Vishal Sood <vishal.sood@...imintegrated.com>");
> > >  MODULE_AUTHOR("David Jung <david.jung@...imintegrated.com>");
> > >  MODULE_LICENSE("GPL v2");
> > > 
> > > +MODULE_IMPORT_NS("IIO_CONSUMER");  
> > 
> > Is this actually needed if we don't use anything from consumer.h?  
> 
> No, it's not.
> 
> Thanks,
>