linux-kernel - Re: [PATCH 0/2] usb: host: Drop resume calls on {e,o}hci_platform

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <db985cbf-4813-44d1-a4c6-16826f935c17@rowland.harvard.edu>
Date: Sun, 7 Dec 2025 11:36:06 -0500
From: Alan Stern <stern@...land.harvard.edu>
To: Biju <biju.das.au@...il.com>
Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Philipp Zabel <p.zabel@...gutronix.de>,
	Biju Das <biju.das.jz@...renesas.com>,
	Claudiu Beznea <claudiu.beznea.uj@...renesas.com>,
	linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org,
	Geert Uytterhoeven <geert+renesas@...der.be>,
	Prabhakar Mahadev Lad <prabhakar.mahadev-lad.rj@...renesas.com>,
	linux-renesas-soc@...r.kernel.org
Subject: Re: [PATCH 0/2] usb: host: Drop resume calls on
 {e,o}hci_platform_suspend()

On Sun, Dec 07, 2025 at 12:47:25PM +0000, Biju wrote:
> From: Biju Das <biju.das.jz@...renesas.com>
> 
> As per the suspend_devices_and_enter() [1], if .suspend() fails, it invoke
> the .resume() callback.

Quite wrong.  If .suspend() fails, the core assumes the device is still 
at full power.  It does not try to resume the device.

> This patch series drops redundant resume() from
> {e,o}hci_platform_suspend()

These resume() calls are not redundant and they should not be dropped.

> [1]
> https://elixir.bootlin.com/linux/v6.18-rc7/source/kernel/power/suspend.c#L519

The message on this line has no bearing on what you are doing.  It 
merely says "Some devices failed to suspend, or early wake event 
detected".  There's nothing about invoking the .resume() callback.

Alan Stern