linux-kernel - Re: [RFC 5/7] gpu: nova-core: set RMSetSriovMode when NVIDIA vGPU is enabled

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <26FAD9BC-9CFC-4BFE-9985-DD660BCD840A@nvidia.com>
Date: Sun, 7 Dec 2025 16:57:01 +0000
From: Joel Fernandes <joelagnelf@...dia.com>
To: Timur Tabi <ttabi@...dia.com>
CC: "linux-pci@...r.kernel.org" <linux-pci@...r.kernel.org>, Zhi Wang
	<zhiw@...dia.com>, "nouveau@...ts.freedesktop.org"
	<nouveau@...ts.freedesktop.org>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>, "rust-for-linux@...r.kernel.org"
	<rust-for-linux@...r.kernel.org>, Kirti Wankhede <kwankhede@...dia.com>,
	"a.hindborg@...nel.org" <a.hindborg@...nel.org>, "markus.probst@...teo.de"
	<markus.probst@...teo.de>, "boqun.feng@...il.com" <boqun.feng@...il.com>, Neo
 Jia <cjia@...dia.com>, "ojeda@...nel.org" <ojeda@...nel.org>, Aniket Agashe
	<aniketa@...dia.com>, "tmgross@...ch.edu" <tmgross@...ch.edu>,
	"alex.gaynor@...il.com" <alex.gaynor@...il.com>, "helgaas@...nel.org"
	<helgaas@...nel.org>, "lossin@...nel.org" <lossin@...nel.org>,
	"alex@...zbot.org" <alex@...zbot.org>, Surath Mitra <smitra@...dia.com>, John
 Hubbard <jhubbard@...dia.com>, Ankit Agrawal <ankita@...dia.com>, Alexandre
 Courbot <acourbot@...dia.com>, "bjorn3_gh@...tonmail.com"
	<bjorn3_gh@...tonmail.com>, "Tarun Gupta (SW-GPU)" <targupta@...dia.com>,
	"zhiwang@...nel.org" <zhiwang@...nel.org>, "airlied@...il.com"
	<airlied@...il.com>, "aliceryhl@...gle.com" <aliceryhl@...gle.com>,
	"kwilczynski@...nel.org" <kwilczynski@...nel.org>, "bhelgaas@...gle.com"
	<bhelgaas@...gle.com>, "gary@...yguo.net" <gary@...yguo.net>,
	"dakr@...nel.org" <dakr@...nel.org>
Subject: Re: [RFC 5/7] gpu: nova-core: set RMSetSriovMode when NVIDIA vGPU is
 enabled



> On Dec 7, 2025, at 10:55 AM, Timur Tabi <ttabi@...dia.com> wrote:
> 
>> On Sat, 2025-12-06 at 12:42 +0000, Zhi Wang wrote:
>> -    pub(crate) fn new() -> Self {
>> +    pub(crate) fn new(vgpu_support: bool) -> Self {
>> +        let num_entries = if vgpu_support { 4 } else { 3 };
> 
> Instead of passing a bool, and then hard-coding the length based on that bool (which would
> require that RMSetSriovMode always be the last entry in the array), you need to do what Nouveau
> does: if VGPU is enabled, then dynamically append the entry to the array.

Yeah, I agree with Timur. 

Thanks.