linux-kernel - Re: [PATCH v4 2/2] iio: adc: Add TI ADS131M0x ADC driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aTYGvaZk_PzouTRf@smile.fi.intel.com>
Date: Mon, 8 Dec 2025 00:59:09 +0200
From: Andy Shevchenko <andriy.shevchenko@...el.com>
To: Jonathan Cameron <jic23@...nel.org>
Cc: Oleksij Rempel <o.rempel@...gutronix.de>, Rob Herring <robh@...nel.org>,
	Krzysztof Kozlowski <krzk+dt@...nel.org>,
	Conor Dooley <conor+dt@...nel.org>,
	David Jander <david@...tonic.nl>, kernel@...gutronix.de,
	linux-kernel@...r.kernel.org, linux-iio@...r.kernel.org,
	devicetree@...r.kernel.org, Andy Shevchenko <andy@...nel.org>,
	David Lechner <dlechner@...libre.com>,
	Nuno Sá <nuno.sa@...log.com>
Subject: Re: [PATCH v4 2/2] iio: adc: Add TI ADS131M0x ADC driver

On Sun, Dec 07, 2025 at 07:33:13PM +0000, Jonathan Cameron wrote:
> On Tue, 18 Nov 2025 15:18:21 +0100
> Oleksij Rempel <o.rempel@...gutronix.de> wrote:

...

> > +	clk = devm_clk_get_enabled(dev, NULL);
> 
> This surprised me, so I went digging.  Anyone know why
> the stub returns NULL?  Given that the normal function doesn't have
> that as an allowed return value that seems really odd.
> 
> Still, it does, so this code is fine if odd.

I believe it has to do something with an optional clocks or so, but OTOH
I think it's so odd that may be considered as a bug in CCF APIs.

> > +	if (IS_ERR_OR_NULL(clk)) {
> > +		if (IS_ERR(clk))
> > +			ret = PTR_ERR(clk);
> > +		else
> > +			ret = -ENODEV;
> > +
> > +		return dev_err_probe(dev, ret, "clk get enabled failed\n");
> > +	}

-- 
With Best Regards,
Andy Shevchenko