linux-kernel - Re: [PATCH v3 2/2] pid: only take pidmap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aTUq5bRdPNpup8GQ@casper.infradead.org>
Date: Sun, 7 Dec 2025 07:21:09 +0000
From: Matthew Wilcox <willy@...radead.org>
To: Mateusz Guzik <mjguzik@...il.com>
Cc: oleg@...hat.com, brauner@...nel.org, linux-kernel@...r.kernel.org,
	akpm@...ux-foundation.org, linux-mm@...ck.org
Subject: Re: [PATCH v3 2/2] pid: only take pidmap_lock once on alloc

On Sat, Dec 06, 2025 at 02:19:55PM +0100, Mateusz Guzik wrote:
> -	if (!pid)
> +	if (unlikely(!pid))

Does this change anything?  I was under the impression that gcc already
treats !p as unlikely.