linux-kernel - Re: [PATCH] bpf: Fix bpf_seq_read docs for increased buffer size

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CABdmKX0QUE7+sJy7CHfrZmBAZAsnpHNrVM6N7MvQO7n76MJoCg@mail.gmail.com>
Date: Sun, 7 Dec 2025 18:12:12 +0900
From: "T.J. Mercier" <tjmercier@...gle.com>
To: Menglong Dong <menglong.dong@...ux.dev>
Cc: Yonghong Song <yonghong.song@...ux.dev>, Alexei Starovoitov <ast@...nel.org>, 
	Daniel Borkmann <daniel@...earbox.net>, Andrii Nakryiko <andrii@...nel.org>, 
	Martin KaFai Lau <martin.lau@...ux.dev>, Eduard Zingerman <eddyz87@...il.com>, Song Liu <song@...nel.org>, 
	John Fastabend <john.fastabend@...il.com>, KP Singh <kpsingh@...nel.org>, 
	Stanislav Fomichev <sdf@...ichev.me>, Hao Luo <haoluo@...gle.com>, Jiri Olsa <jolsa@...nel.org>, 
	Alan Maguire <alan.maguire@...cle.com>, bpf@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] bpf: Fix bpf_seq_read docs for increased buffer size

On Sun, Dec 7, 2025 at 2:08 PM Menglong Dong <menglong.dong@...ux.dev> wrote:
>
> On 12/7/25 8:58 AM, T.J. Mercier wrote:
> > Commit af65320948b8 ("bpf: Bump iter seq size to support BTF
> > representation of large data structures") increased the fixed buffer
> > size from PAGE_SIZE to PAGE_SIZE << 3, but the docs for the function
> > didn't get updated at the same time. Update them.
> >
> > Fixes: af65320948b8 ("bpf: Bump iter seq size to support BTF representation of large data structures")
>
> I think we don't need the "Fixes" tag for the document fix?
> Therefore, it's better to go to the "bpf-next" tree with the
> corresponding tag:
>   [PATCH bpf-next]
>
> Thanks!
> Menglong Dong

SGTM, resent to bpf-next at:
https://lore.kernel.org/bpf/20251207091005.2829703-1-tjmercier@google.com/T/#u

Thanks!
-T.J.

> > Signed-off-by: T.J. Mercier <tjmercier@...gle.com>
> > ---
> >  kernel/bpf/bpf_iter.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/kernel/bpf/bpf_iter.c b/kernel/bpf/bpf_iter.c
> > index eec60b57bd3d..4b58d56ecab1 100644
> > --- a/kernel/bpf/bpf_iter.c
> > +++ b/kernel/bpf/bpf_iter.c
> > @@ -86,7 +86,7 @@ static bool bpf_iter_support_resched(struct seq_file *seq)
> >
> >  /* bpf_seq_read, a customized and simpler version for bpf iterator.
> >   * The following are differences from seq_read():
> > - *  . fixed buffer size (PAGE_SIZE)
> > + *  . fixed buffer size (PAGE_SIZE << 3)
> >   *  . assuming NULL ->llseek()
> >   *  . stop() may call bpf program, handling potential overflow there
> >   */
> >
>
>
>
>