linux-kernel - Re: [PATCH v2 3/3] mshv: Add debugfs to view hypervisor statistics

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202512081050.0AW9Ecvg-lkp@intel.com>
Date: Mon, 8 Dec 2025 11:04:20 +0800
From: kernel test robot <lkp@...el.com>
To: Nuno Das Neves <nunodasneves@...ux.microsoft.com>,
	linux-hyperv@...r.kernel.org, linux-kernel@...r.kernel.org,
	skinsburskii@...ux.microsoft.com
Cc: oe-kbuild-all@...ts.linux.dev, kys@...rosoft.com,
	haiyangz@...rosoft.com, wei.liu@...nel.org, decui@...rosoft.com,
	longli@...rosoft.com, mhklinux@...look.com,
	prapal@...ux.microsoft.com, mrathor@...ux.microsoft.com,
	paekkaladevi@...ux.microsoft.com,
	Nuno Das Neves <nunodasneves@...ux.microsoft.com>,
	Jinank Jain <jinankjain@...rosoft.com>
Subject: Re: [PATCH v2 3/3] mshv: Add debugfs to view hypervisor statistics

Hi Nuno,

kernel test robot noticed the following build warnings:

[auto build test WARNING on next-20251205]
[cannot apply to linus/master v6.18 v6.18-rc7 v6.18-rc6 v6.18]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Nuno-Das-Neves/mshv-Ignore-second-stats-page-map-result-failure/20251206-033756
base:   next-20251205
patch link:    https://lore.kernel.org/r/1764961122-31679-4-git-send-email-nunodasneves%40linux.microsoft.com
patch subject: [PATCH v2 3/3] mshv: Add debugfs to view hypervisor statistics
config: x86_64-randconfig-002-20251208 (https://download.01.org/0day-ci/archive/20251208/202512081050.0AW9Ecvg-lkp@intel.com/config)
compiler: gcc-12 (Debian 12.4.0-5) 12.4.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20251208/202512081050.0AW9Ecvg-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202512081050.0AW9Ecvg-lkp@intel.com/

All warnings (new ones prefixed by >>):

   drivers/hv/mshv_root_main.c: In function 'mshv_parent_partition_init':
>> drivers/hv/mshv_root_main.c:2369:1: warning: label 'destroy_irqds_wq' defined but not used [-Wunused-label]
    2369 | destroy_irqds_wq:
         | ^~~~~~~~~~~~~~~~


vim +/destroy_irqds_wq +2369 drivers/hv/mshv_root_main.c

  2299	
  2300	static int __init mshv_parent_partition_init(void)
  2301	{
  2302		int ret;
  2303		struct device *dev;
  2304		union hv_hypervisor_version_info version_info;
  2305	
  2306		if (!hv_parent_partition() || is_kdump_kernel())
  2307			return -ENODEV;
  2308	
  2309		if (hv_get_hypervisor_version(&version_info))
  2310			return -ENODEV;
  2311	
  2312		ret = misc_register(&mshv_dev);
  2313		if (ret)
  2314			return ret;
  2315	
  2316		dev = mshv_dev.this_device;
  2317	
  2318		if (version_info.build_number < MSHV_HV_MIN_VERSION ||
  2319		    version_info.build_number > MSHV_HV_MAX_VERSION) {
  2320			dev_err(dev, "Running on unvalidated Hyper-V version\n");
  2321			dev_err(dev, "Versions: current: %u  min: %u  max: %u\n",
  2322				version_info.build_number, MSHV_HV_MIN_VERSION,
  2323				MSHV_HV_MAX_VERSION);
  2324		}
  2325	
  2326		mshv_root.synic_pages = alloc_percpu(struct hv_synic_pages);
  2327		if (!mshv_root.synic_pages) {
  2328			dev_err(dev, "Failed to allocate percpu synic page\n");
  2329			ret = -ENOMEM;
  2330			goto device_deregister;
  2331		}
  2332	
  2333		ret = cpuhp_setup_state(CPUHP_AP_ONLINE_DYN, "mshv_synic",
  2334					mshv_synic_init,
  2335					mshv_synic_cleanup);
  2336		if (ret < 0) {
  2337			dev_err(dev, "Failed to setup cpu hotplug state: %i\n", ret);
  2338			goto free_synic_pages;
  2339		}
  2340	
  2341		mshv_cpuhp_online = ret;
  2342	
  2343		ret = mshv_retrieve_scheduler_type(dev);
  2344		if (ret)
  2345			goto remove_cpu_state;
  2346	
  2347		if (hv_root_partition())
  2348			ret = mshv_root_partition_init(dev);
  2349		if (ret)
  2350			goto remove_cpu_state;
  2351	
  2352		mshv_init_vmm_caps(dev);
  2353	
  2354		ret = mshv_debugfs_init();
  2355		if (ret)
  2356			goto exit_partition;
  2357	
  2358		ret = mshv_irqfd_wq_init();
  2359		if (ret)
  2360			goto exit_debugfs;
  2361	
  2362		spin_lock_init(&mshv_root.pt_ht_lock);
  2363		hash_init(mshv_root.pt_htable);
  2364	
  2365		hv_setup_mshv_handler(mshv_isr);
  2366	
  2367		return 0;
  2368	
> 2369	destroy_irqds_wq:
  2370		mshv_irqfd_wq_cleanup();
  2371	exit_debugfs:
  2372		mshv_debugfs_exit();
  2373	exit_partition:
  2374		if (hv_root_partition())
  2375			mshv_root_partition_exit();
  2376	remove_cpu_state:
  2377		cpuhp_remove_state(mshv_cpuhp_online);
  2378	free_synic_pages:
  2379		free_percpu(mshv_root.synic_pages);
  2380	device_deregister:
  2381		misc_deregister(&mshv_dev);
  2382		return ret;
  2383	}
  2384	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki