linux-kernel - Re: Kconfig dangling references (BZ 216748)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20251208200555.GA333481@robin.jannau.net>
Date: Mon, 8 Dec 2025 21:05:55 +0100
From: Janne Grunau <j@...nau.net>
To: Paul Kocialkowski <paulk@...-base.io>
Cc: Randy Dunlap <rdunlap@...radead.org>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Andy Shevchenko <andy.shevchenko@...il.com>,
	Arnd Bergmann <arnd@...db.de>, andrew.jones@...ux.dev,
	linux-omap@...r.kernel.org, openbmc@...ts.ozlabs.org,
	linux-sound@...r.kernel.org,
	Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
	linux-mips@...r.kernel.org, asahi@...ts.linux.dev,
	"dri-devel@...ts.freedesktop.org" <dri-devel@...ts.freedesktop.org>,
	chrome-platform@...ts.linux.dev,
	Paul Cercueil <paul@...pouillou.net>,
	linux-stm32@...md-mailman.stormreply.com,
	Linux ARM <linux-arm-kernel@...ts.infradead.org>,
	linux-gpio@...r.kernel.org, Srinivas Kandagatla <srini@...nel.org>,
	Philipp Zabel <p.zabel@...gutronix.de>,
	Matti Vaittinen <mazziesaccount@...il.com>,
	Jonathan Cameron <jic23@...nel.org>,
	Vaibhav Hiremath <hvaibhav.linux@...il.com>,
	linux-sh@...r.kernel.org, x86@...nel.org,
	Max Filippov <jcmvbkbc@...il.com>
Subject: Re: Kconfig dangling references (BZ 216748)

On Mon, Dec 08, 2025 at 07:13:50PM +0100, Paul Kocialkowski wrote:
> Hi Randy,
> 
> On Sun 07 Dec 25, 18:04, Randy Dunlap wrote:
> > from  https://bugzilla.kernel.org/show_bug.cgi?id=216748
> > 
> > The bugzilla entry includes a Perl script and a shell script.
> > This is the edited result of running them (I removed some entries that were noise).
> 
> [...]
> 
> > DRM_KMS_DMA_HELPER ---
> > drivers/gpu/drm/adp/Kconfig:9:	select DRM_KMS_DMA_HELPER
> > drivers/gpu/drm/logicvc/Kconfig:7:	select DRM_KMS_DMA_HELPER
> 
> For these two, the symbol was removed in commit
> 09717af7d13d63df141ae6e71686289989d17efd

That commit removed DRM_KMS_CMA_HELPER. Later commit 6bcfe8eaeef0
("drm/fb: rename FB CMA helpers to FB DMA helpers") renamed
DRM_KMS_CMA_HELPER erroneously to DRM_KMS_DMA_HELPER.

> but these two drivers either were
> missed by the batch rename or were introduced a bit later.

In the case of drivers/gpu/drm/adp/Kconfig it was missed much later
during review (but iirc went through the same rename out of tree).

> Since the symbol selected DRM_GEM_CMA_HELPER (which is still needed by the
> drivers), it should be replaced with DRM_GEM_CMA_HELPER.

That symbol doesn't exist anymore either. It's now DRM_GEM_DMA_HELPER
which is already present in both files.

So the "select DRM_KMS_DMA_HELPER" lines can be removed from both files.

Janne