linux-kernel - Re: [PATCH] ufs: qcom: Fix confusing cleanup.h syntax

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <lpneh6skxhpkalzvpjjresw3akxzzxmizohfzjtwgplzpjbsjc@yje4z22fbhcp>
Date: Mon, 8 Dec 2025 14:16:19 +0900
From: Manivannan Sadhasivam <mani@...nel.org>
To: Krzysztof Kozlowski <krzysztof.kozlowski@....qualcomm.com>
Cc: "James E.J. Bottomley" <James.Bottomley@...senpartnership.com>, 
	"Martin K. Petersen" <martin.petersen@...cle.com>, linux-arm-msm@...r.kernel.org, linux-scsi@...r.kernel.org, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ufs: qcom: Fix confusing cleanup.h syntax

On Mon, Dec 08, 2025 at 03:08:08AM +0100, Krzysztof Kozlowski wrote:
> Initializing automatic __free variables to NULL without need (e.g.
> branches with different allocations), followed by actual allocation is
> in contrary to explicit coding rules guiding cleanup.h:
> 
> "Given that the "__free(...) = NULL" pattern for variables defined at
> the top of the function poses this potential interdependency problem the
> recommendation is to always define and assign variables in one statement
> and not group variable definitions at the top of the function when
> __free() is used."
> 
> Code does not have a bug, but is less readable and uses discouraged
> coding practice, so fix that by moving declaration to the place of
> assignment.
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@....qualcomm.com>

Thanks. On the side note, I would recommend adding this check to checkpatch to
warn people in the first place.

Reviewed-by: Manivannan Sadhasivam <mani@...nel.org>

- Mani

> ---
>  drivers/ufs/host/ufs-qcom.c | 6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/ufs/host/ufs-qcom.c b/drivers/ufs/host/ufs-qcom.c
> index 8d119b3223cb..8ebee0cc5313 100644
> --- a/drivers/ufs/host/ufs-qcom.c
> +++ b/drivers/ufs/host/ufs-qcom.c
> @@ -1769,10 +1769,9 @@ static void ufs_qcom_dump_testbus(struct ufs_hba *hba)
>  {
>  	struct ufs_qcom_host *host = ufshcd_get_variant(hba);
>  	int i, j, nminor = 0, testbus_len = 0;
> -	u32 *testbus __free(kfree) = NULL;
>  	char *prefix;
>  
> -	testbus = kmalloc_array(256, sizeof(u32), GFP_KERNEL);
> +	u32 *testbus __free(kfree) = kmalloc_array(256, sizeof(u32), GFP_KERNEL);
>  	if (!testbus)
>  		return;
>  
> @@ -1794,13 +1793,12 @@ static void ufs_qcom_dump_testbus(struct ufs_hba *hba)
>  static int ufs_qcom_dump_regs(struct ufs_hba *hba, size_t offset, size_t len,
>  			      const char *prefix, void __iomem *base)
>  {
> -	u32 *regs __free(kfree) = NULL;
>  	size_t pos;
>  
>  	if (offset % 4 != 0 || len % 4 != 0)
>  		return -EINVAL;
>  
> -	regs = kzalloc(len, GFP_ATOMIC);
> +	u32 *regs __free(kfree) = kzalloc(len, GFP_ATOMIC);
>  	if (!regs)
>  		return -ENOMEM;
>  
> -- 
> 2.51.0
> 

-- 
மணிவண்ணன் சதாசிவம்