linux-kernel - Re: [PATCH 2/4] pwm: sun50i: Add H616 PWM support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b5731ee5-8a16-40f1-8418-07c45a97c609@kernel.org>
Date: Mon, 8 Dec 2025 07:09:16 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Richard Genoud <richard.genoud@...tlin.com>,
 Uwe Kleine-König <u.kleine-koenig@...libre.com>,
 Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
 Conor Dooley <conor+dt@...nel.org>, Chen-Yu Tsai <wens@...e.org>,
 Jernej Skrabec <jernej.skrabec@...il.com>,
 Samuel Holland <samuel@...lland.org>, Philipp Zabel <p.zabel@...gutronix.de>
Cc: Thomas Petazzoni <thomas.petazzoni@...tlin.com>,
 linux-pwm@...r.kernel.org, devicetree@...r.kernel.org,
 linux-arm-kernel@...ts.infradead.org, linux-sunxi@...ts.linux.dev,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/4] pwm: sun50i: Add H616 PWM support

On 05/12/2025 11:02, Richard Genoud wrote:
> +static struct platform_driver h616_pwm_driver = {
> +	.driver = {
> +		.name = "h616-pwm",
> +		.of_match_table = h616_pwm_dt_ids,
> +	},
> +	.probe = h616_pwm_probe,
> +};
> +module_platform_driver(h616_pwm_driver);
> +
> +MODULE_ALIAS("platform:h616-pwm");

You should not need MODULE_ALIAS() in normal cases. If you need it,
usually it means your device ID table is wrong (e.g. misses either
entries or MODULE_DEVICE_TABLE()). MODULE_ALIAS() is not a substitute
for incomplete ID table.


> +MODULE_AUTHOR("Richard Genoud <richard.genoud@...tlin.com>");
> +MODULE_DESCRIPTION("Allwinner H616 PWM driver");
> +MODULE_LICENSE("GPL");


Best regards,
Krzysztof