linux-kernel - Re: [PATCH v8 1/5] media: dt-bindings: Add CAMSS device for Kaanapali

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2tvkcuipfaa7cn7goynt6jfzlcxg2d7yvvjqizb6p7sf5oqwuj@drqiyr3khoyf>
Date: Mon, 8 Dec 2025 03:44:55 +0200
From: Dmitry Baryshkov <dmitry.baryshkov@....qualcomm.com>
To: Bryan O'Donoghue <bryan.odonoghue@...aro.org>
Cc: Hangxiang Ma <hangxiang.ma@....qualcomm.com>,
        Loic Poulain <loic.poulain@....qualcomm.com>,
        Robert Foss <rfoss@...nel.org>, Andi Shyti <andi.shyti@...nel.org>,
        Rob Herring <robh@...nel.org>,
        Krzysztof Kozlowski <krzk+dt@...nel.org>,
        Conor Dooley <conor+dt@...nel.org>, Todor Tomov <todor.too@...il.com>,
        Vladimir Zapolskiy <vladimir.zapolskiy@...aro.org>,
        Mauro Carvalho Chehab <mchehab@...nel.org>,
        linux-arm-msm@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-media@...r.kernel.org,
        aiqun.yu@....qualcomm.com, tingwei.zhang@....qualcomm.com,
        trilok.soni@....qualcomm.com, yijie.yang@....qualcomm.com,
        Jingyi Wang <jingyi.wang@....qualcomm.com>,
        Atiya Kailany <atiya.kailany@....qualcomm.com>,
        Krzysztof Kozlowski <krzk@...nel.org>
Subject: Re: [PATCH v8 1/5] media: dt-bindings: Add CAMSS device for Kaanapali

On Sat, Dec 06, 2025 at 10:11:20PM +0000, Bryan O'Donoghue wrote:
> On 01/12/2025 06:30, Hangxiang Ma wrote:
> > Add the compatible string "qcom,kaanapali-camss" to describe the Camera
> > Subsystem (CAMSS) on the Qualcomm Kaanapali platform.
> > 
> > The Kaanapali platform provides:
> > - 3 x VFE, 5 RDI per VFE
> > - 2 x VFE Lite, 4 RDI per VFE Lite
> > - 3 x CSID
> > - 2 x CSID Lite
> > - 6 x CSIPHY
> > - 2 x ICP
> > - 1 x IPE
> > - 2 x JPEG DMA & Downscaler
> > - 2 x JPEG Encoder
> > - 1 x OFE
> > - 5 x RT CDM
> > - 3 x TPG
> > 
> > Reviewed-by: Bryan O'Donoghue <bryan.odonoghue@...aro.org>
> > Reviewed-by: Krzysztof Kozlowski <krzk@...nel.org>
> > Signed-off-by: Hangxiang Ma <hangxiang.ma@....qualcomm.com>
> > ---
> >   .../bindings/media/qcom,kaanapali-camss.yaml       | 647 +++++++++++++++++++++
> >   1 file changed, 647 insertions(+)
> > 

> > +      - const: gcc_hf_axi
> 
> https://patchwork.linuxtv.org/project/linux-media/patch/20251126-add-support-for-camss-on-sm8750-v1-2-646fee2eb720@oss.qualcomm.com/
> 
> Pointed out by Krzysztof in the 8750 patches but the name of this clock is
> gcc_axi_hf.
> 
> ~/Development/worktree/qcom-linux-next
> ➞  grep gcc_axi_hf * -r | wc -l              [git:platform-qcom-next] ✖
> 48
> 
> ~/Development/worktree/qcom-linux-next
> ➞  grep gcc_hf_axi * -r | wc -l              [git:platform-qcom-next] ✖
> 0

My 2c: it should be none of those. gcc_axi_hf is the _source_ of the
clock, while the bindings (in my opinion) should be describing the
function of the clock on the consumer side (e.g. bus, iface, something
else, etc).

> 
> Please resolve the other inconsitencies pointed out by Krzysztof in that
> thread here also.
> 
> I will have to skip application of this series in the meantime.
> 
> ---
> bod

-- 
With best wishes
Dmitry