[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20251208062943.68824-4-sj@kernel.org>
Date: Sun, 7 Dec 2025 22:29:07 -0800
From: SeongJae Park <sj@...nel.org>
To:
Cc: SeongJae Park <sj@...nel.org>,
Andrew Morton <akpm@...ux-foundation.org>,
damon@...ts.linux.dev,
linux-kernel@...r.kernel.org,
linux-mm@...ck.org
Subject: [RFC PATCH v3 03/37] mm/damon/core: commit damon_sample_control
The parameters for sampling primitives usage control is not committed
with damon_commit_ctx(). Hence it doesn't work with online parameters
update. Implement the functionality.
Signed-off-by: SeongJae Park <sj@...nel.org>
---
mm/damon/core.c | 21 +++++++++++++++++++++
1 file changed, 21 insertions(+)
diff --git a/mm/damon/core.c b/mm/damon/core.c
index 7abd8c550c60..89305d42e116 100644
--- a/mm/damon/core.c
+++ b/mm/damon/core.c
@@ -559,6 +559,8 @@ struct damon_ctx *damon_new_ctx(void)
ctx->attrs.min_nr_regions = 10;
ctx->attrs.max_nr_regions = 1000;
+ ctx->sample_control.primitives_enabled.page_table = true;
+
ctx->addr_unit = 1;
ctx->min_sz_region = DAMON_MIN_REGION;
@@ -1242,6 +1244,23 @@ static int damon_commit_targets(
return 0;
}
+static bool damon_primitives_enabled_invalid(
+ struct damon_primitives_enabled *config)
+{
+ return config->page_table == config->page_fault;
+}
+
+static int damon_commit_sample_control(
+ struct damon_sample_control *dst,
+ struct damon_sample_control *src)
+{
+ if (damon_primitives_enabled_invalid(&src->primitives_enabled))
+ return -EINVAL;
+
+ dst->primitives_enabled = src->primitives_enabled;
+ return 0;
+}
+
/**
* damon_commit_ctx() - Commit parameters of a DAMON context to another.
* @dst: The commit destination DAMON context.
@@ -1278,6 +1297,8 @@ int damon_commit_ctx(struct damon_ctx *dst, struct damon_ctx *src)
return err;
}
dst->ops = src->ops;
+ err = damon_commit_sample_control(&dst->sample_control,
+ &src->sample_control);
if (err)
return err;
dst->addr_unit = src->addr_unit;
--
2.47.3
Powered by blists - more mailing lists