linux-kernel - Re: [PATCH v4 1/2] dt-bindings: iio: pressure: add honeywell,abp2030pa

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aTZ7G8M-FvmEuQ8X@lipo.home.arpa>
Date: Mon, 8 Dec 2025 09:15:39 +0200
From: Petre Rodan <petre.rodan@...dimension.ro>
To: Krzysztof Kozlowski <krzk@...nel.org>
Cc: Jonathan Cameron <jic23@...nel.org>,
	David Lechner <dlechner@...libre.com>,
	Nuno Sá <nuno.sa@...log.com>,
	Andy Shevchenko <andy@...nel.org>, Rob Herring <robh@...nel.org>,
	Krzysztof Kozlowski <krzk+dt@...nel.org>,
	Conor Dooley <conor+dt@...nel.org>, linux-iio@...r.kernel.org,
	devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v4 1/2] dt-bindings: iio: pressure: add
 honeywell,abp2030pa


hello Krzysztof, 

On Mon, Dec 08, 2025 at 06:01:46AM +0100, Krzysztof Kozlowski wrote:
> On 07/12/2025 07:00, Petre Rodan wrote:
> > Adds binding for digital Honeywell ABP2 series pressure and temperature
> > sensors.
> > The i2c address is hardcoded and depends on the part number.
> > There is an optional interrupt that signals the end of conversion.
> > 
> > Signed-off-by: Petre Rodan <petre.rodan@...dimension.ro>
> 
> <form letter>
> This is a friendly reminder during the review process.
> 
> It looks like you received a tag and forgot to add it.

[..]

> If a tag was not added on purpose, please state why and what changed.
> </form letter>

I removed the tag on purpose since the yaml file was modified in v4 as per the
changelog that is below the commit message.

> I will not be doing work twice and, without explanation, forcing me to
> do that is disrespectful to my time.

sorry about that. the single thing that changed was that

---- 8< --------------------------------------------
@@ -76,8 +71,7 @@ properties:
   spi-max-frequency:
     maximum: 800000
 
-  vdd-supply:
-    description: provide VDD power to the sensor.
+  vdd-supply: true
 
 required:
   - compatible
---- >8 --------------------------------------------

I checked the resulting file with make dt_binding_check, yet I was not sure if your previous tag would still validate the work.

best regards,
peter