linux-kernel - Re: [PATCH] scsi: libsas: Fix potential array out of bounds in sas_check_*_expander

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <6209f1aa126aff9b3c0cc6d90129aa3e34f72f81.camel@HansenPartnership.com>
Date: Mon, 08 Dec 2025 16:47:09 +0900
From: James Bottomley <James.Bottomley@...senPartnership.com>
To: Chaohai Chen <wdhh6@...yun.com>, john.g.garry@...cle.com, 
	yanaijie@...wei.com, martin.petersen@...cle.com, dlemoal@...nel.org, 
	mingo@...nel.org, cassel@...nel.org, tglx@...utronix.de
Cc: linux-scsi@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] scsi: libsas: Fix potential array out of bounds in
 sas_check_*_expander_topo().

On Mon, 2025-12-08 at 15:31 +0800, Chaohai Chen wrote:
> No check was made to ensure that parent_phy->appended_phy_id is
> within the valid range. If the expander reports an invalid phy_id, it
> may cause the array to be out of bounds.

We tend to assume hardware operates correctly unless there's a known
faulty device that we need to code around.  Have you got a device that
exhibits this problem?  Assuming you do, I think the fix is a little
harsh: wouldn't it be better to ignore the misnumbered phy than to
ignore the entire expander?

Regards,

James