linux-kernel - Re: [PATCH] ublk: allow non-blocking ctrl cmds in IO_URING_F

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aTaFZqtFvlAi5KrR@fedora>
Date: Mon, 8 Dec 2025 15:59:34 +0800
From: Ming Lei <ming.lei@...hat.com>
To: Caleb Sander Mateos <csander@...estorage.com>
Cc: Jens Axboe <axboe@...nel.dk>, linux-block@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ublk: allow non-blocking ctrl cmds in
 IO_URING_F_NONBLOCK issue

On Mon, Dec 01, 2025 at 02:41:44PM -0700, Caleb Sander Mateos wrote:
> Handling most of the ublksrv_ctrl_cmd opcodes require locking a mutex,
> so ublk_ctrl_uring_cmd() bails out with EAGAIN when called with the
> IO_URING_F_NONBLOCK issue flag. However, several opcodes can be handled
> without blocking:
> - UBLK_CMD_GET_QUEUE_AFFINITY
> - UBLK_CMD_GET_DEV_INFO
> - UBLK_CMD_GET_DEV_INFO2
> - UBLK_U_CMD_GET_FEATURES
> 
> Handle these opcodes synchronously instead of returning EAGAIN so
> io_uring doesn't need to issue the command via the worker thread pool.
> 
> Signed-off-by: Caleb Sander Mateos <csander@...estorage.com>

Reviewed-by: Ming Lei <ming.lei@...hat.com>


Thanks,
Ming