linux-kernel - Re: [PATCH] bug: hush suggest-attribute=format for __warn

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20251208083857.GA3707837@noisy.programming.kicks-ass.net>
Date: Mon, 8 Dec 2025 09:38:57 +0100
From: Peter Zijlstra <peterz@...radead.org>
To: Brendan Jackman <jackmanb@...gle.com>
Cc: Andrew Morton <akpm@...ux-foundation.org>, linux-kernel@...r.kernel.org,
	kees@...nel.org, acarmina@...hat.com, jpoimboe@...nel.org,
	mark.rutland@....com, maciej.wieczor-retman@...el.com
Subject: Re: [PATCH] bug: hush suggest-attribute=format for __warn_printf()

On Sun, Dec 07, 2025 at 03:53:18AM +0000, Brendan Jackman wrote:
> Recent additions to this function cause GCC 14.3.0 to get excited and
> suggest a missing attribute:
> 
> lib/bug.c: In function ‘__warn_printf’:
> lib/bug.c:187:25: error: function ‘__warn_printf’ might be a candidate for ‘gnu_printf’ format attribute [-Werror=suggest-attribute=format]
>   187 |                         vprintk(fmt, *args);
>       |                         ^~~~~~~
> 
> Disable the diagnostic locally, following the pattern used for stuff
> like va_format().

No real objection, but why haven't I seen this in my own builds? Most of
my machines are on gcc-14 / gcc-15.