linux-kernel - [PATCH] staging: rtl8723bs: fix missing status update on sdio_alloc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-Id: <20251208092730.262499-1-buaajxlj@163.com>
Date: Mon,  8 Dec 2025 17:27:28 +0800
From: Liang Jie <buaajxlj@....com>
To: Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Alexandre Viard <xela@...rd.dev>,
	Liang Jie <liangjie@...iang.com>,
	fanggeng <fanggeng@...iang.com>,
	Michael Straube <straube.linux@...il.com>,
	Hans de Goede <hansg@...nel.org>,
	linux-staging@...ts.linux.dev (open list:STAGING SUBSYSTEM),
	linux-kernel@...r.kernel.org (open list)
Cc: yangchen11@...iang.com,
	stable@...r.kernel.org
Subject: [PATCH] staging: rtl8723bs: fix missing status update on sdio_alloc_irq() failure

From: Liang Jie <liangjie@...iang.com>

The return value of sdio_alloc_irq() was not stored in status.
If sdio_alloc_irq() fails after rtw_drv_register_netdev() succeeds,
status remains _SUCCESS and the error path skips resource cleanup,
while rtw_drv_init() still returns success.

Store the return value of sdio_alloc_irq() in status and reuse the
existing error handling which relies on status.

Cc: stable@...r.kernel.org
Fixes: 554c0a3abf21 ("staging: Add rtl8723bs sdio wifi driver")
Reviewed-by: fanggeng <fanggeng@...iang.com>
Signed-off-by: Liang Jie <liangjie@...iang.com>
---
 drivers/staging/rtl8723bs/os_dep/sdio_intf.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/staging/rtl8723bs/os_dep/sdio_intf.c b/drivers/staging/rtl8723bs/os_dep/sdio_intf.c
index f3caaa857c86..139ace51486d 100644
--- a/drivers/staging/rtl8723bs/os_dep/sdio_intf.c
+++ b/drivers/staging/rtl8723bs/os_dep/sdio_intf.c
@@ -377,7 +377,8 @@ static int rtw_drv_init(
 	if (status != _SUCCESS)
 		goto free_if1;
 
-	if (sdio_alloc_irq(dvobj) != _SUCCESS)
+	status = sdio_alloc_irq(dvobj);
+	if (status != _SUCCESS)
 		goto free_if1;
 
 	status = _SUCCESS;
-- 
2.25.1