linux-kernel - Re: [PATCH] ASoC: cs35l41: Always return 0 when a subsystem ID is found

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6d10da69-65bb-4dff-97d3-8c4a387a94fe@opensource.cirrus.com>
Date: Mon, 8 Dec 2025 09:31:02 +0000
From: Richard Fitzgerald <rf@...nsource.cirrus.com>
To: Eric Naim <dnaim@...hyos.org>, David Rhodes <david.rhodes@...rus.com>,
        Liam Girdwood <lgirdwood@...il.com>, Mark Brown <broonie@...nel.org>,
        Jaroslav Kysela <perex@...ex.cz>, Takashi Iwai <tiwai@...e.com>,
        Stefan Binding <sbinding@...nsource.cirrus.com>
Cc: stable@...r.kernel.org, linux-sound@...r.kernel.org,
        patches@...nsource.cirrus.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ASoC: cs35l41: Always return 0 when a subsystem ID is
 found

On 06/12/2025 7:38 pm, Eric Naim wrote:
> When trying to get the system name in the _HID path, after successfully
> retrieving the subsystem ID the return value isn't set to 0 but instead
> still kept at -ENODATA, leading to a false negative:
> 
> [   12.382507] cs35l41 spi-VLV1776:00: Subsystem ID: VLV1776
> [   12.382521] cs35l41 spi-VLV1776:00: probe with driver cs35l41 failed with error -61
> 
> Always return 0 when a subsystem ID is found to mitigate these false
> negatives.
> 
> Link: https://github.com/CachyOS/CachyOS-Handheld/issues/83
> Fixes: 46c8b4d2a693 ("ASoC: cs35l41: Fallback to reading Subsystem ID property if not ACPI")
> Cc: stable@...r.kernel.org # 6.18
> Signed-off-by: Eric Naim <dnaim@...hyos.org>
> ---
>   sound/soc/codecs/cs35l41.c | 7 ++++---
>   1 file changed, 4 insertions(+), 3 deletions(-)
> 
> diff --git a/sound/soc/codecs/cs35l41.c b/sound/soc/codecs/cs35l41.c
> index 173d7c59b725..5001a546a3e7 100644
> --- a/sound/soc/codecs/cs35l41.c
> +++ b/sound/soc/codecs/cs35l41.c
> @@ -1188,13 +1188,14 @@ static int cs35l41_get_system_name(struct cs35l41_private *cs35l41)
>   		}
>   	}
>   
> -err:
>   	if (sub) {
>   		cs35l41->dsp.system_name = sub;
>   		dev_info(cs35l41->dev, "Subsystem ID: %s\n", cs35l41->dsp.system_name);
> -	} else
> -		dev_warn(cs35l41->dev, "Subsystem ID not found\n");
> +		return 0;
> +	}
>   
> +err:
> +	dev_warn(cs35l41->dev, "Subsystem ID not found\n");
>   	return ret;
>   }
>   
Reviewed-by: Richard Fitzgerald <rf@...nsource.cirrus.com>