linux-kernel - Re: [PATCH v2] platform/x86: int3472: Use actual clock frequency for DSM method

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aTa2B3p-6PmJR6DZ@kekkonen.localdomain>
Date: Mon, 8 Dec 2025 13:27:03 +0200
From: Sakari Ailus <sakari.ailus@...ux.intel.com>
To: Hao Yao <hao.yao@...el.com>
Cc: platform-driver-x86@...r.kernel.org, johannes.goede@....qualcomm.com,
	dan.scally@...asonboard.com, ilpo.jarvinen@...ux.intel.com,
	bingbu.cao@...el.com, linux-media@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] platform/x86: int3472: Use actual clock frequency for
 DSM method

Hi Hao,

On Mon, Dec 08, 2025 at 11:51:14AM +0800, Hao Yao wrote:
> The third argument (args[2]) to the _DSM method was hardcoded to 1,
> which corresponds to 19.2MHz. However, this argument should reflect
> the actual clock frequency from the sensor's ACPI data.
> 
> According to the DSM specification:
> - 1 = 19.2MHz
> - 3 = 24MHz
> 
> Read the frequency from clk->frequency and set the DSM argument
> accordingly, with 19.2MHz as the default for unsupported frequencies.
> 
> This ensures the sensor receives the correct clock frequency as
> specified in its ACPI configuration.
> 
> Signed-off-by: Hao Yao <hao.yao@...el.com>

Thanks for the update.

Acked-by: Sakari Ailus <sakari.ailus@...ux.intel.com>

-- 
Kind regards,

Sakari Ailus