| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <20251208121020.1780402-13-agruenba@redhat.com>
Date: Mon, 8 Dec 2025 12:10:19 +0000
From: Andreas Gruenbacher <agruenba@...hat.com>
To: Christoph Hellwig <hch@...radead.org>,
Jens Axboe <axboe@...nel.dk>,
Chris Mason <clm@...com>,
David Sterba <dsterba@...e.com>
Cc: Andreas Gruenbacher <agruenba@...hat.com>,
linux-block@...r.kernel.org,
linux-btrfs@...r.kernel.org,
linux-raid@...r.kernel.org,
dm-devel@...ts.linux.dev,
linux-kernel@...r.kernel.org
Subject: [RFC 12/12] bio: add bio_endio_status
Add a bio_endio_status() helper as a shortcut for calling
bio_set_status() and bio_endio() in sequence. Use the new helper
throughout the code.
Created with Coccinelle using the following semantic patch:
@@
expression bio, status;
@@
- bio_set_status(bio, status);
- bio_endio(bio);
+ bio_endio_status(bio, status);
Signed-off-by: Andreas Gruenbacher <agruenba@...hat.com>
---
block/bio-integrity-auto.c | 3 +--
block/blk-core.c | 6 ++----
block/blk-mq.c | 6 ++----
drivers/block/drbd/drbd_req.c | 3 +--
drivers/block/ps3vram.c | 3 +--
drivers/md/dm-cache-target.c | 3 +--
drivers/md/dm-integrity.c | 15 +++++----------
drivers/md/dm-mpath.c | 3 +--
drivers/md/dm-raid1.c | 3 +--
drivers/md/dm-thin.c | 3 +--
drivers/md/dm.c | 3 +--
drivers/md/raid1-10.c | 3 +--
drivers/md/raid10.c | 6 ++----
include/linux/bio.h | 12 ++++++++----
14 files changed, 28 insertions(+), 44 deletions(-)
diff --git a/block/bio-integrity-auto.c b/block/bio-integrity-auto.c
index 736d53a7f699..1185f6e15d86 100644
--- a/block/bio-integrity-auto.c
+++ b/block/bio-integrity-auto.c
@@ -190,8 +190,7 @@ bool bio_integrity_prep(struct bio *bio)
err_free_buf:
kfree(buf);
err_end_io:
- bio_set_status(bio, BLK_STS_RESOURCE);
- bio_endio(bio);
+ bio_endio_status(bio, BLK_STS_RESOURCE);
return false;
}
EXPORT_SYMBOL(bio_integrity_prep);
diff --git a/block/blk-core.c b/block/blk-core.c
index 95cbb3ffcf9f..8b36674dc09a 100644
--- a/block/blk-core.c
+++ b/block/blk-core.c
@@ -640,8 +640,7 @@ static void __submit_bio(struct bio *bio)
if ((bio->bi_opf & REQ_POLLED) &&
!(disk->queue->limits.features & BLK_FEAT_POLL)) {
- bio_set_status(bio, BLK_STS_NOTSUPP);
- bio_endio(bio);
+ bio_endio_status(bio, BLK_STS_NOTSUPP);
} else {
disk->fops->submit_bio(bio);
}
@@ -882,8 +881,7 @@ void submit_bio_noacct(struct bio *bio)
not_supported:
status = BLK_STS_NOTSUPP;
end_io:
- bio_set_status(bio, status);
- bio_endio(bio);
+ bio_endio_status(bio, status);
}
EXPORT_SYMBOL(submit_bio_noacct);
diff --git a/block/blk-mq.c b/block/blk-mq.c
index 503ca259429f..10933de73205 100644
--- a/block/blk-mq.c
+++ b/block/blk-mq.c
@@ -3164,8 +3164,7 @@ void blk_mq_submit_bio(struct bio *bio)
}
if ((bio->bi_opf & REQ_POLLED) && !blk_mq_can_poll(q)) {
- bio_set_status(bio, BLK_STS_NOTSUPP);
- bio_endio(bio);
+ bio_endio_status(bio, BLK_STS_NOTSUPP);
goto queue_exit;
}
@@ -3205,8 +3204,7 @@ void blk_mq_submit_bio(struct bio *bio)
ret = blk_crypto_rq_get_keyslot(rq);
if (ret != BLK_STS_OK) {
- bio_set_status(bio, ret);
- bio_endio(bio);
+ bio_endio_status(bio, ret);
blk_mq_free_request(rq);
return;
}
diff --git a/drivers/block/drbd/drbd_req.c b/drivers/block/drbd/drbd_req.c
index 5bedc972b622..41dbf8bbcd61 100644
--- a/drivers/block/drbd/drbd_req.c
+++ b/drivers/block/drbd/drbd_req.c
@@ -1209,8 +1209,7 @@ drbd_request_prepare(struct drbd_device *device, struct bio *bio)
/* only pass the error to the upper layers.
* if user cannot handle io errors, that's not our business. */
drbd_err(device, "could not kmalloc() req\n");
- bio_set_status(bio, BLK_STS_RESOURCE);
- bio_endio(bio);
+ bio_endio_status(bio, BLK_STS_RESOURCE);
return ERR_PTR(-ENOMEM);
}
diff --git a/drivers/block/ps3vram.c b/drivers/block/ps3vram.c
index 06844674c998..8b8bdfa50c97 100644
--- a/drivers/block/ps3vram.c
+++ b/drivers/block/ps3vram.c
@@ -573,8 +573,7 @@ static struct bio *ps3vram_do_bio(struct ps3_system_bus_device *dev,
next = bio_list_peek(&priv->list);
spin_unlock_irq(&priv->lock);
- bio_set_status(bio, error);
- bio_endio(bio);
+ bio_endio_status(bio, error);
return next;
}
diff --git a/drivers/md/dm-cache-target.c b/drivers/md/dm-cache-target.c
index d1dbd4ddaadb..da1b1eb29bb8 100644
--- a/drivers/md/dm-cache-target.c
+++ b/drivers/md/dm-cache-target.c
@@ -1856,8 +1856,7 @@ static void requeue_deferred_bios(struct cache *cache)
bio_list_merge_init(&bios, &cache->deferred_bios);
while ((bio = bio_list_pop(&bios))) {
- bio_set_status(bio, BLK_STS_DM_REQUEUE);
- bio_endio(bio);
+ bio_endio_status(bio, BLK_STS_DM_REQUEUE);
cond_resched();
}
}
diff --git a/drivers/md/dm-integrity.c b/drivers/md/dm-integrity.c
index 90780a112009..06e5cdfdec7d 100644
--- a/drivers/md/dm-integrity.c
+++ b/drivers/md/dm-integrity.c
@@ -2513,8 +2513,7 @@ static int dm_integrity_map_inline(struct dm_integrity_io *dio, bool from_map)
sector_t recalc_sector;
if (unlikely(bio_integrity(bio))) {
- bio_set_status(bio, BLK_STS_NOTSUPP);
- bio_endio(bio);
+ bio_endio_status(bio, BLK_STS_NOTSUPP);
return DM_MAPIO_SUBMITTED;
}
@@ -2535,8 +2534,7 @@ static int dm_integrity_map_inline(struct dm_integrity_io *dio, bool from_map)
if (dio->payload_len > x_size) {
unsigned sectors = ((x_size - extra_size) / ic->tuple_size) << ic->sb->log2_sectors_per_block;
if (WARN_ON(!sectors || sectors >= bio_sectors(bio))) {
- bio_set_status(bio, BLK_STS_NOTSUPP);
- bio_endio(bio);
+ bio_endio_status(bio, BLK_STS_NOTSUPP);
return DM_MAPIO_SUBMITTED;
}
dm_accept_partial_bio(bio, sectors);
@@ -2615,8 +2613,7 @@ static int dm_integrity_map_inline(struct dm_integrity_io *dio, bool from_map)
ret = bio_integrity_add_page(bio, virt_to_page(dio->integrity_payload),
dio->payload_len, offset_in_page(dio->integrity_payload));
if (unlikely(ret != dio->payload_len)) {
- bio_set_status(bio, BLK_STS_RESOURCE);
- bio_endio(bio);
+ bio_endio_status(bio, BLK_STS_RESOURCE);
return DM_MAPIO_SUBMITTED;
}
@@ -2668,8 +2665,7 @@ static void dm_integrity_inline_recheck(struct work_struct *w)
r = bio_integrity_add_page(outgoing_bio, virt_to_page(dio->integrity_payload), ic->tuple_size, 0);
if (unlikely(r != ic->tuple_size)) {
bio_put(outgoing_bio);
- bio_set_status(bio, BLK_STS_RESOURCE);
- bio_endio(bio);
+ bio_endio_status(bio, BLK_STS_RESOURCE);
return;
}
@@ -2691,8 +2687,7 @@ static void dm_integrity_inline_recheck(struct work_struct *w)
dm_audit_log_bio(DM_MSG_PREFIX, "integrity-checksum",
bio, dio->bio_details.bi_iter.bi_sector, 0);
- bio_set_status(bio, BLK_STS_PROTECTION);
- bio_endio(bio);
+ bio_endio_status(bio, BLK_STS_PROTECTION);
return;
}
diff --git a/drivers/md/dm-mpath.c b/drivers/md/dm-mpath.c
index 761e5e79d4a7..1097ffb05b00 100644
--- a/drivers/md/dm-mpath.c
+++ b/drivers/md/dm-mpath.c
@@ -722,8 +722,7 @@ static void process_queued_bios(struct work_struct *work)
bio_io_error(bio);
break;
case DM_MAPIO_REQUEUE:
- bio_set_status(bio, BLK_STS_DM_REQUEUE);
- bio_endio(bio);
+ bio_endio_status(bio, BLK_STS_DM_REQUEUE);
break;
case DM_MAPIO_REMAPPED:
submit_bio_noacct(bio);
diff --git a/drivers/md/dm-raid1.c b/drivers/md/dm-raid1.c
index c54995847db0..1f53b125b333 100644
--- a/drivers/md/dm-raid1.c
+++ b/drivers/md/dm-raid1.c
@@ -627,8 +627,7 @@ static void write_callback(unsigned long error, void *context)
* degrade the array.
*/
if (bio_op(bio) == REQ_OP_DISCARD) {
- bio_set_status(bio, BLK_STS_NOTSUPP);
- bio_endio(bio);
+ bio_endio_status(bio, BLK_STS_NOTSUPP);
return;
}
diff --git a/drivers/md/dm-thin.c b/drivers/md/dm-thin.c
index bd061a6bf016..ae8850a3e728 100644
--- a/drivers/md/dm-thin.c
+++ b/drivers/md/dm-thin.c
@@ -2731,8 +2731,7 @@ static int thin_bio_map(struct dm_target *ti, struct bio *bio)
thin_hook_bio(tc, bio);
if (tc->requeue_mode) {
- bio_set_status(bio, BLK_STS_DM_REQUEUE);
- bio_endio(bio);
+ bio_endio_status(bio, BLK_STS_DM_REQUEUE);
return DM_MAPIO_SUBMITTED;
}
diff --git a/drivers/md/dm.c b/drivers/md/dm.c
index cbc64377fa96..1743042db9f6 100644
--- a/drivers/md/dm.c
+++ b/drivers/md/dm.c
@@ -983,8 +983,7 @@ static void __dm_io_complete(struct dm_io *io, bool first_stage)
queue_io(md, bio);
} else {
/* done with normal IO or empty flush */
- bio_set_status(bio, io_error);
- bio_endio(bio);
+ bio_endio_status(bio, io_error);
}
}
diff --git a/drivers/md/raid1-10.c b/drivers/md/raid1-10.c
index 504730aba9df..53903bb91408 100644
--- a/drivers/md/raid1-10.c
+++ b/drivers/md/raid1-10.c
@@ -104,8 +104,7 @@ static void md_bio_reset_resync_pages(struct bio *bio, struct resync_pages *rp,
int len = min_t(int, size, PAGE_SIZE);
if (WARN_ON(!bio_add_page(bio, page, len, 0))) {
- bio_set_status(bio, BLK_STS_RESOURCE);
- bio_endio(bio);
+ bio_endio_status(bio, BLK_STS_RESOURCE);
return;
}
diff --git a/drivers/md/raid10.c b/drivers/md/raid10.c
index 7cc27819beb5..7750d6577b83 100644
--- a/drivers/md/raid10.c
+++ b/drivers/md/raid10.c
@@ -3681,8 +3681,7 @@ static sector_t raid10_sync_request(struct mddev *mddev, sector_t sector_nr,
struct resync_pages *rp = get_resync_pages(bio);
page = resync_fetch_page(rp, page_idx);
if (WARN_ON(!bio_add_page(bio, page, len, 0))) {
- bio_set_status(bio, BLK_STS_RESOURCE);
- bio_endio(bio);
+ bio_endio_status(bio, BLK_STS_RESOURCE);
goto giveup;
}
}
@@ -4863,8 +4862,7 @@ static sector_t reshape_request(struct mddev *mddev, sector_t sector_nr,
len = PAGE_SIZE;
for (bio = blist; bio ; bio = bio->bi_next) {
if (WARN_ON(!bio_add_page(bio, page, len, 0))) {
- bio_set_status(bio, BLK_STS_RESOURCE);
- bio_endio(bio);
+ bio_endio_status(bio, BLK_STS_RESOURCE);
return sectors_done;
}
}
diff --git a/include/linux/bio.h b/include/linux/bio.h
index 06fb8ae018c4..8f6ac5fa0a12 100644
--- a/include/linux/bio.h
+++ b/include/linux/bio.h
@@ -382,17 +382,21 @@ static inline void bio_set_status(struct bio *bio, blk_status_t status)
WRITE_ONCE(bio->bi_status, status);
}
-static inline void bio_io_error(struct bio *bio)
+static inline void bio_endio_status(struct bio *bio, blk_status_t status)
{
- bio_set_status(bio, BLK_STS_IOERR);
+ bio_set_status(bio, status);
bio_endio(bio);
}
+static inline void bio_io_error(struct bio *bio)
+{
+ bio_endio_status(bio, BLK_STS_IOERR);
+}
+
static inline void bio_wouldblock_error(struct bio *bio)
{
bio_set_flag(bio, BIO_QUIET);
- bio_set_status(bio, BLK_STS_AGAIN);
- bio_endio(bio);
+ bio_endio_status(bio, BLK_STS_AGAIN);
}
blk_status_t errno_to_blk_status(int errno);
--
2.51.0
Powered by blists - more mailing lists