linux-kernel - Re: [PATCH] fsi: master-gpio: Fix reference count leak in probe error path

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2c9af5ae-c250-4760-a9bb-aeec61c61eb1@web.de>
Date: Mon, 8 Dec 2025 16:10:50 +0100
From: Markus Elfring <Markus.Elfring@....de>
To: vulab@...as.ac.cn, linux-fsi@...ts.ozlabs.org,
 Eddie James <eajames@...ux.ibm.com>, Ninad Palsule <ninad@...ux.ibm.com>
Cc: stable@...r.kernel.org, LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] fsi: master-gpio: Fix reference count leak in probe error
 path

…
> Add the missing of_node_put() in the error handling path to properly
> release the device tree node reference.
…
> +++ b/drivers/fsi/fsi-master-gpio.c
> @@ -861,6 +861,7 @@ static int fsi_master_gpio_probe(struct platform_device *pdev)
>  	}
>  	return 0;
>   err_free:
> +	of_node_put(master->master.dev.of_node);

Is there a need to rename the label accordingly?


>  	kfree(master);

Can it be helpful to move the statement “rc = PTR_ERR(gpio);”
also into the exception handling of this function implementation?


>  	return rc;
>  }
…


Regards,
Markus