[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <8510a763-adfa-4f9c-9502-ca4787dd25a1@oss.qualcomm.com>
Date: Mon, 8 Dec 2025 16:26:45 +0100
From: Konrad Dybcio <konrad.dybcio@....qualcomm.com>
To: Luca Weiss <luca@...aweiss.eu>, Bjorn Andersson <andersson@...nel.org>,
Konrad Dybcio <konradybcio@...nel.org>, Rob Herring <robh@...nel.org>,
Krzysztof Kozlowski <krzk+dt@...nel.org>,
Conor Dooley
<conor+dt@...nel.org>,
Jens Reidel <adrian@...nlining.org>, Bhushan Shah <bshah@....org>
Cc: ~postmarketos/upstreaming@...ts.sr.ht, phone-devel@...r.kernel.org,
linux-arm-msm@...r.kernel.org, devicetree@...r.kernel.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ARM: dts: qcom: msm8974-hammerhead: Update model property
On 12/8/25 1:41 PM, Luca Weiss wrote:
> Many years have passed (more than 9 actually) since the introduction of
> the Nexus 5 dts to Linux and it's high time to update the model property
> to be a proper model name and thereby bringing it to the standards of
> the 2020s.
>
> Signed-off-by: Luca Weiss <luca@...aweiss.eu>
> ---
> The phone was manufactured by LG and sold by Google. Some sources call
> it LG Nexus 5, some Google Nexus 5. I think it was mostly marketed as
> just Nexus 5, but consensus in upstream dts seems to be to use the
> manufacturer, see Nexus 5X, Nexus 6P, Nexus 4.
>
> Arguments could also easily be made to change the compatible to
> "lg,hammerhead" and rename the dts, since lge (LG Electronics) is not
> even documented in vendor-prefixes and doesn't really appear anywhere
> else in the kernel and lg, (for LG Corporation, the parent of LG
> Electronics from what I can tell) is used. But that's more invasive so
> I'm leaving this out in favor of this simple patch.
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@....qualcomm.com>
Konrad
Powered by blists - more mailing lists