linux-kernel - Re: [PATCH v3 3/3] iio: adc: ad9467: drop kernel.h in favor of array

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aTb1vEEJRY6Uom2l@smile.fi.intel.com>
Date: Mon, 8 Dec 2025 17:58:52 +0200
From: Andy Shevchenko <andriy.shevchenko@...el.com>
To: Tomas Melin <tomas.melin@...sala.com>
Cc: Lars-Peter Clausen <lars@...afoo.de>,
	Michael Hennerich <Michael.Hennerich@...log.com>,
	Nuno Sa <nuno.sa@...log.com>, Jonathan Cameron <jic23@...nel.org>,
	David Lechner <dlechner@...libre.com>,
	Andy Shevchenko <andy@...nel.org>, Rob Herring <robh@...nel.org>,
	Krzysztof Kozlowski <krzk+dt@...nel.org>,
	Conor Dooley <conor+dt@...nel.org>, linux-iio@...r.kernel.org,
	devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 3/3] iio: adc: ad9467: drop kernel.h in favor of
 array_size.h

On Mon, Dec 08, 2025 at 05:41:20PM +0200, Tomas Melin wrote:
> On 08/12/2025 15:20, Andy Shevchenko wrote:
> > On Mon, Dec 08, 2025 at 12:30:59PM +0000, Tomas Melin wrote:
> >> No need to include the entire kernel.h when the only thing needed
> >> is the ARRAY_SIZE macro.
> > 
> > ARRAY_SIZE().

Please, remove context you are agree with.

...

> >>  #include <linux/module.h>
> >>  #include <linux/mutex.h>
> >>  #include <linux/device.h>
> >> -#include <linux/kernel.h>
> >> +#include <linux/array_size.h>
> >>  #include <linux/slab.h>
> >>  #include <linux/spi/spi.h>
> >>  #include <linux/seq_file.h>
> > 
> > Please, keep them sorted.
> These were unfortunately not sorted to start with.

But your patch makes situation even worse. That's what I meant by the comment.
Since there is no a* header, it may be put to the proper location from day 1.

...

> > While this change is almost (*) okay per se, I think we can address more
> > while at it.
> > - Make the header inclusions ordered (also fix the location of clk.h)
> > - drop other proxy (device.h) or unneeded headers (bitops.h as it's implied by bitmap.h)
> > - add missing ones (dev_printk.h, device/devres.h, ...)
> 
> As this change (kernel.h) does not seem at all as straightforward as I
> envisoned based on your initial request, I will likely change this patch
> to instead just sort the headers. Reworking the includes is separate
> topic from the intent of this patch series.

If you don't feel going that deep, than it's a (small) problem.

As the author of a driver feature one should understand slightly more about
this (yeah, currently mess) header stuff. So, your first patch should add
missed headers, if any, that's required to your changes, this one can be
omitted after all.

But on some day you will still need to understand a bit more about headers...

TL;DR: make sure you have all needed headers for your changes in the previous
patch and drop this one.

> > (*) no, kernel.h provides more for this driver, for example, your patch
> > misses types.h.

-- 
With Best Regards,
Andy Shevchenko