linux-kernel - Re: [PATCH 1/2] dt-bindings: phy: ti,tcan104x-can: Document TI TCAN1046

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CA+V-a8tuP-C_0=atz0WXtw2mqNfjsaYCkDdsQE3QwyhFWTSSJg@mail.gmail.com>
Date: Mon, 8 Dec 2025 16:08:41 +0000
From: "Lad, Prabhakar" <prabhakar.csengg@...il.com>
To: Frank Li <Frank.li@....com>
Cc: Marc Kleine-Budde <mkl@...gutronix.de>, Vincent Mailhol <mailhol@...nel.org>, 
	Vinod Koul <vkoul@...nel.org>, Neil Armstrong <neil.armstrong@...aro.org>, 
	Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>, 
	Aswath Govindraju <a-govindraju@...com>, linux-can@...r.kernel.org, 
	linux-phy@...ts.infradead.org, devicetree@...r.kernel.org, 
	linux-kernel@...r.kernel.org, linux-renesas-soc@...r.kernel.org, 
	Biju Das <biju.das.jz@...renesas.com>, 
	Fabrizio Castro <fabrizio.castro.jz@...esas.com>, 
	Lad Prabhakar <prabhakar.mahadev-lad.rj@...renesas.com>
Subject: Re: [PATCH 1/2] dt-bindings: phy: ti,tcan104x-can: Document TI TCAN1046

Hi Frank,

Thank you for the review.

On Mon, Dec 8, 2025 at 4:01 PM Frank Li <Frank.li@....com> wrote:
>
> On Mon, Dec 08, 2025 at 03:50:18PM +0000, Prabhakar wrote:
> > From: Lad Prabhakar <prabhakar.mahadev-lad.rj@...renesas.com>
> >
> > Document the TI TCAN1046 automotive CAN transceiver. The TCAN1046
> > provides dual high-speed CAN channels and includes STB1/2 control
> > lines.
> >
> > Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@...renesas.com>
> > ---
> >  Documentation/devicetree/bindings/phy/ti,tcan104x-can.yaml | 5 ++++-
> >  1 file changed, 4 insertions(+), 1 deletion(-)
> >
> > diff --git a/Documentation/devicetree/bindings/phy/ti,tcan104x-can.yaml b/Documentation/devicetree/bindings/phy/ti,tcan104x-can.yaml
> > index c686d06f5f56..c53c4f703102 100644
> > --- a/Documentation/devicetree/bindings/phy/ti,tcan104x-can.yaml
> > +++ b/Documentation/devicetree/bindings/phy/ti,tcan104x-can.yaml
> > @@ -23,6 +23,7 @@ properties:
> >        - enum:
> >            - ti,tcan1042
> >            - ti,tcan1043
> > +          - ti,tcan1046
>
> according to patch2, which is the compatible as nxp,tja1048. why not allow
> ti,tcan1046 fallback to nxp,tja1048.
>
> So needn't change driver code.
>
Agreed, I'll do this change and send a v2.

Cheers,
Prabhakar

> Frank
> >            - nxp,tja1048
> >            - nxp,tja1051
> >            - nxp,tja1057
> > @@ -84,7 +85,9 @@ allOf:
> >        properties:
> >          compatible:
> >            contains:
> > -            const: nxp,tja1048
> > +            enum:
> > +              - ti,tcan1046
> > +              - nxp,tja1048
> >      then:
> >        properties:
> >          '#phy-cells':
> > --
> > 2.52.0
> >