linux-kernel - Re: [PATCH 3/7] drm/amdgpu: don't abuse current->group

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b230d9a0-761e-4b71-bdbd-0a7bf193865b@amd.com>
Date: Tue, 9 Dec 2025 14:22:53 -0500
From: Felix Kuehling <felix.kuehling@....com>
To: Oleg Nesterov <oleg@...hat.com>, Todd Kjos <tkjos@...roid.com>,
 Martijn Coenen <maco@...roid.com>, Joel Fernandes <joelagnelf@...dia.com>,
 Christian Brauner <brauner@...nel.org>, Carlos Llamas <cmllamas@...gle.com>,
 Suren Baghdasaryan <surenb@...gle.com>,
 Alex Deucher <alexander.deucher@....com>,
 Christian König <christian.koenig@....com>,
 David Airlie <airlied@...il.com>, Simona Vetter <simona@...ll.ch>,
 Boris Brezillon <boris.brezillon@...labora.com>,
 Rob Herring <robh@...nel.org>, Steven Price <steven.price@....com>,
 Adrián Larumbe <adrian.larumbe@...labora.com>,
 Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>,
 Maxime Ripard <mripard@...nel.org>, Thomas Zimmermann <tzimmermann@...e.de>,
 Liviu Dudau <liviu.dudau@....com>, Jason Gunthorpe <jgg@...pe.ca>,
 Leon Romanovsky <leon@...nel.org>, "David S. Miller" <davem@...emloft.net>,
 Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>,
 Paolo Abeni <pabeni@...hat.com>
Cc: linux-kernel@...r.kernel.org, amd-gfx@...ts.freedesktop.org,
 dri-devel@...ts.freedesktop.org, linux-rdma@...r.kernel.org,
 netdev@...r.kernel.org
Subject: Re: [PATCH 3/7] drm/amdgpu: don't abuse current->group_leader

On 2025-12-07 07:39, Oleg Nesterov wrote:
> Cleanup and preparation to simplify the next changes.
>
> - Use current->tgid instead of current->group_leader->pid
>
> - Use get_task_pid(current, PIDTYPE_TGID) instead of
>    get_task_pid(current->group_leader, PIDTYPE_PID)
>
> Signed-off-by: Oleg Nesterov <oleg@...hat.com>

Acked-by: Felix Kuehling <felix.kuehling@....com>

> ---
>   drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c | 2 +-
>   drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c           | 2 +-
>   2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c
> index b1c24c8fa686..df22b54ba346 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c
> @@ -1421,7 +1421,7 @@ static int init_kfd_vm(struct amdgpu_vm *vm, void **process_info,
>   			goto create_evict_fence_fail;
>   		}
>   
> -		info->pid = get_task_pid(current->group_leader, PIDTYPE_PID);
> +		info->pid = get_task_pid(current, PIDTYPE_TGID);
>   		INIT_DELAYED_WORK(&info->restore_userptr_work,
>   				  amdgpu_amdkfd_restore_userptr_worker);
>   
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c
> index a67285118c37..a0f8ba382b9e 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c
> @@ -2554,7 +2554,7 @@ void amdgpu_vm_set_task_info(struct amdgpu_vm *vm)
>   	if (current->group_leader->mm != current->mm)
>   		return;
>   
> -	vm->task_info->tgid = current->group_leader->pid;
> +	vm->task_info->tgid = current->tgid;
>   	get_task_comm(vm->task_info->process_name, current->group_leader);
>   }
>