linux-kernel - Re: [PATCH net-next] net/tcp_sigpool: Enable compile-testing

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aTh3W-SoRxiWN38e@horms.kernel.org>
Date: Tue, 9 Dec 2025 19:24:11 +0000
From: Simon Horman <horms@...nel.org>
To: Geert Uytterhoeven <geert+renesas@...der.be>
Cc: Eric Biggers <ebiggers@...nel.org>,
	Dmitry Safonov <0x7f454c46@...il.com>,
	Francesco Ruggeri <fruggeri@...sta.com>,
	Salam Noureddine <noureddine@...sta.com>,
	"David S. Miller" <davem@...emloft.net>,
	David Ahern <dsahern@...nel.org>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next] net/tcp_sigpool: Enable compile-testing

On Thu, Dec 04, 2025 at 03:57:31PM +0100, Geert Uytterhoeven wrote:
> Since commit 37a183d3b7cdb873 ("tcp: Convert tcp-md5 to use MD5 library
> instead of crypto_ahash"), TCP_SIGPOOL is only selected by TCP_AO.
> However, the latter depends on 64BIT, so tcp_sigpool can no longer be
> built on 32-bit platforms at all.
> 
> Improve compile coverage on 32-bit by allowing the user to enable
> TCP_SIGPOOL when compile-testing.  Add a dependency on CRYPTO, which is
> always fulfilled when selected by TCP_AO.
> 
> Signed-off-by: Geert Uytterhoeven <geert+renesas@...der.be>
> ---
> One remaining oddity is that TCP_SIGPOOL has always been a tristate
> symbol, while all users that select it have always been boolean symbols.
> I kept that as-is, as it builds fine as a module.

Hi Geert,

I tested some of the COMPILE_TEST/TCP_AO
combinations and this seems to work as expected.

Reviewed-by: Simon Horman <horms@...nel.org>

However,

## Form letter - net-next-closed

The merge window for v6.19 has begun and therefore net-next has closed
for new drivers, features, code refactoring and optimizations. We are
currently accepting bug fixes only.

Please repost when net-next reopens.

Due to a combination of the merge-window, travel commitments of the
maintainers, and the holiday season, net-next will re-open after
2nd January.

RFC patches sent for review only are welcome at any time.

See: https://www.kernel.org/doc/html/next/process/maintainer-netdev.html#development-cycle

-- 
pw-bot: defer