linux-kernel - Re: [PATCH v15 07/32] x86,fs/resctrl: Use struct rdt_domain

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7974688a-7d12-4c59-be05-c5f4dff580f3@intel.com>
Date: Tue, 9 Dec 2025 11:38:22 -0800
From: Reinette Chatre <reinette.chatre@...el.com>
To: Tony Luck <tony.luck@...el.com>, Fenghua Yu <fenghuay@...dia.com>, "Maciej
 Wieczor-Retman" <maciej.wieczor-retman@...el.com>, Peter Newman
	<peternewman@...gle.com>, James Morse <james.morse@....com>, Babu Moger
	<babu.moger@....com>, Drew Fustini <dfustini@...libre.com>, Dave Martin
	<Dave.Martin@....com>, Chen Yu <yu.c.chen@...el.com>
CC: <x86@...nel.org>, <linux-kernel@...r.kernel.org>,
	<patches@...ts.linux.dev>
Subject: Re: [PATCH v15 07/32] x86,fs/resctrl: Use struct rdt_domain_hdr when
 reading counters

Hi Tony,

On 12/4/25 12:53 PM, Tony Luck wrote:
> Convert the whole call sequence from mon_event_read() to resctrl_arch_rmid_read()
> to pass resource independent struct rdt_domain_hdr instead of an L3 specific
> domain structure to prepare for monitoring events in other resources.

Please add a snippet to inform reader about the additional change that splits the
event counting flow. Here is a draft of the idea to start:

	This additional layer of indirection obscures which aspects of event counting depend
	on a valid domain. Event initialization, support for assignable counters, and normal
	event counting implicitly depend on a valid domain while summing of domains does not.
	Split summing domains from the core event counting handling to make their respective
	dependencies obvious.

> 
> Signed-off-by: Tony Luck <tony.luck@...el.com>
> ---

| Reviewed-by: Reinette Chatre <reinette.chatre@...el.com>

Reinette