linux-kernel - Re: [PATCH v3 01/10] crypto: virtio: Add spinlock protection with virtqueue notification

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <832af71e-c4a1-6745-bae0-ba77f8a66142@loongson.cn>
Date: Tue, 9 Dec 2025 10:26:34 +0800
From: Bibo Mao <maobibo@...ngson.cn>
To: Gonglei <arei.gonglei@...wei.com>, "Michael S . Tsirkin"
 <mst@...hat.com>, Jason Wang <jasowang@...hat.com>,
 Xuan Zhuo <xuanzhuo@...ux.alibaba.com>, Eugenio Pérez
 <eperezma@...hat.com>, Herbert Xu <herbert@...dor.apana.org.au>,
 "David S. Miller" <davem@...emloft.net>,
 wangyangxin <wangyangxin1@...wei.com>
Cc: virtualization@...ts.linux.dev, linux-crypto@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 01/10] crypto: virtio: Add spinlock protection with
 virtqueue notification

oops, the cover letter is missing again since I forgot to add 
linux-kernel@...r.kernel.org in cc list manually and command 
"scripts/get_maintainer.pl --nogit --nogit-fallback --norolestats" has 
no any effect on cover letter :(

please ignore this patch set.

Regards
Bibo Mao

On 2025/12/9 上午9:59, Bibo Mao wrote:
> When VM boots with one virtio-crypto PCI device and builtin backend,
> run openssl benchmark command with multiple processes, such as
>    openssl speed -evp aes-128-cbc -engine afalg  -seconds 10 -multi 32
> 
> openssl processes will hangup and there is error reported like this:
>   virtio_crypto virtio0: dataq.0:id 3 is not a head!
> 
> It seems that the data virtqueue need protection when it is handled
> for virtio done notification. If the spinlock protection is added
> in virtcrypto_done_task(), openssl benchmark with multiple processes
> works well.
> 
> Fixes: fed93fb62e05 ("crypto: virtio - Handle dataq logic with tasklet")
> Cc: stable@...r.kernel.org
> Signed-off-by: Bibo Mao <maobibo@...ngson.cn>
> ---
>   drivers/crypto/virtio/virtio_crypto_core.c | 5 +++++
>   1 file changed, 5 insertions(+)
> 
> diff --git a/drivers/crypto/virtio/virtio_crypto_core.c b/drivers/crypto/virtio/virtio_crypto_core.c
> index 3d241446099c..ccc6b5c1b24b 100644
> --- a/drivers/crypto/virtio/virtio_crypto_core.c
> +++ b/drivers/crypto/virtio/virtio_crypto_core.c
> @@ -75,15 +75,20 @@ static void virtcrypto_done_task(unsigned long data)
>   	struct data_queue *data_vq = (struct data_queue *)data;
>   	struct virtqueue *vq = data_vq->vq;
>   	struct virtio_crypto_request *vc_req;
> +	unsigned long flags;
>   	unsigned int len;
>   
> +	spin_lock_irqsave(&data_vq->lock, flags);
>   	do {
>   		virtqueue_disable_cb(vq);
>   		while ((vc_req = virtqueue_get_buf(vq, &len)) != NULL) {
> +			spin_unlock_irqrestore(&data_vq->lock, flags);
>   			if (vc_req->alg_cb)
>   				vc_req->alg_cb(vc_req, len);
> +			spin_lock_irqsave(&data_vq->lock, flags);
>   		}
>   	} while (!virtqueue_enable_cb(vq));
> +	spin_unlock_irqrestore(&data_vq->lock, flags);
>   }
>   
>   static void virtcrypto_dataq_callback(struct virtqueue *vq)
>