linux-kernel - Re: [PATCH 1/2] dt-bindings: pwm: eswin: Add EIC7700 pwm controller

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <502cc1eb-87a6-4574-903a-6181cd2258cc@kernel.org>
Date: Tue, 9 Dec 2025 22:40:55 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Xuyang Dong <dongxuyang@...incomputing.com>, ben.dooks@...ethink.co.uk
Cc: ukleinek@...nel.org, robh@...nel.org, krzk+dt@...nel.org,
 conor+dt@...nel.org, p.zabel@...gutronix.de, linux-pwm@...r.kernel.org,
 devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
 ningyu@...incomputing.com, linmin@...incomputing.com,
 xuxiang@...incomputing.com, wangguosheng@...incomputing.com,
 pinkesh.vaghela@...fochips.com
Subject: Re: [PATCH 1/2] dt-bindings: pwm: eswin: Add EIC7700 pwm controller

On 09/12/2025 11:20, Xuyang Dong wrote:
>>> +
>>> +  pinctrl-0: true
>>> +  pinctrl-1: true
>>> +
>>> +  pinctrl-names:
>>> +    minItems: 1
>>> +    items:
>>> +      - const: default
>>> +      - const: sleep
>>> +
>>> +  snps,pwm-full-range-enable:
>>
>> 1. Wrong vendor prefix, thats eswin, not snps.
>> 2. Why is this a hardware property? I really do not see that. You
>> described the desired Linux feature or behavior, not the actual
>> hardware. The bindings are about the latter, so instead you need to
>> rephrase the property and its description to match actual hardware
>> capabilities/features/configuration etc.
>>
> Hi Krzysztof and Ben,
> 
> There is a patch [1] submmitted by Ben Dook a few years ago. The 
> intention of this patch is to make DWC pwm controller can be used as 
> platform driver. This is what we are currently working on.
> It seems that it would be more reasonable to continue improving this 
> patch and make the DWC PWM driver universal, rather than creating a 
> separate ESWIN PWM driver.
> 
> The DWC pwm 2.13a version supports "Pulse Width Modulation with 0% and 
> 100% Duty Cycle" by programming TIMER_0N100PWM_EN bit field. We also 
> want to support this new hardware feature. So, adding a new property, 
> like snps,timer-0n100pwm-en, in pwm/snps,dw-apb-timers-pwm2.yaml
> would be better?
> 
> Krzysztof and Ben, do you think the above approach is reasonable and acceptable?


How any of this is related to the binding? We talk here about hardware
and binding, but you ask me about driver.... I don't care.

Best regards,
Krzysztof