linux-kernel - Re: [PATCH 1/2] hung_task: Consolidate hung task warning into an atomic log block

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <iwx2qvhrzvamlcxg5xnby3552aexr6myqajwhdtopielsnebfi@h3vzew3ao7bb>
Date: Tue, 9 Dec 2025 17:11:33 -0500
From: Aaron Tomlin <atomlin@...mlin.com>
To: Lance Yang <lance.yang@...ux.dev>
Cc: sean@...e.io, linux-kernel@...r.kernel.org, mhiramat@...nel.org, 
	akpm@...ux-foundation.org, Petr Mladek <pmladek@...e.com>, gregkh@...uxfoundation.org
Subject: Re: [PATCH 1/2] hung_task: Consolidate hung task warning into an
 atomic log block

On Tue, Dec 09, 2025 at 01:12:14PM +0800, Lance Yang wrote:
> > +	       "      %s %s %.*s\n"
> > +	       "%s\n"
> 
> "%s\n" forces an unconditional newline, causing a spurious blank line when
> the flag isn't set, right?

Yes, apologies. I will resolve the above in a subsequent patch.

> Since there's only one caller, why not just open-code it ...

Acknowledged.

> TBH, jamming everything into a single pr_err() call doesn't look any
> cleaner to me than the original code :(

Agreed on the aesthetics; however, the technical motivation is sound. This
method is required to generate a non-interleaved diagnostic block and avoid
losing contextual information in high-concurrency logging. This is an area
of concern for us.

Kind regards,
-- 
Aaron Tomlin

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)