| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <20251209224024.2322124-1-irogers@google.com> Date: Tue, 9 Dec 2025 14:40:24 -0800 From: Ian Rogers <irogers@...gle.com> To: Steven Rostedt <rostedt@...dmis.org>, Masami Hiramatsu <mhiramat@...nel.org>, Mathieu Desnoyers <mathieu.desnoyers@...icios.com>, linux-kernel@...r.kernel.org, linux-trace-kernel@...r.kernel.org Cc: Ian Rogers <irogers@...gle.com> Subject: [PATCH v1] tracing: Avoid possible signed 64-bit truncation 64-bit truncation to 32-bit can result in the sign of the truncated value changing. The cmp_mod_entry is used in bsearch and so the truncation could result in an invalid search order. This would only happen were the addresses more than 2GB apart and so unlikely, but let's fix the potentially broken compare anyway. Signed-off-by: Ian Rogers <irogers@...gle.com> --- kernel/trace/trace.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/kernel/trace/trace.c b/kernel/trace/trace.c index d1e527cf2aae..e6a80cbe9326 100644 --- a/kernel/trace/trace.c +++ b/kernel/trace/trace.c @@ -6057,8 +6057,10 @@ static int cmp_mod_entry(const void *key, const void *pivot) if (addr >= ent[0].mod_addr && addr < ent[1].mod_addr) return 0; + else if (addr > ent->mod_addr) + return 1; else - return addr - ent->mod_addr; + return -1; } /** -- 2.52.0.223.gf5cc29aaa4-goog
Powered by blists - more mailing lists