linux-kernel - Re: [PATCH] firmware: stratix10-svc: Delete some stray tabs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <0e9fbd34-9916-455c-b6c0-816837033325@kernel.org>
Date: Tue, 9 Dec 2025 17:40:03 -0600
From: Dinh Nguyen <dinguyen@...nel.org>
To: Dan Carpenter <dan.carpenter@...aro.org>,
 Mahesh Rao <mahesh.rao@...era.com>, Richard Gong <richard.gong@...el.com>
Cc: linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org
Subject: Re: [PATCH] firmware: stratix10-svc: Delete some stray tabs



On 11/21/25 07:34, Dan Carpenter wrote:
> These lines are indented one tab too far.  Delete the extra tabs
> for readability.
> 
> Signed-off-by: Dan Carpenter <dan.carpenter@...aro.org>
> ---
>   drivers/firmware/stratix10-svc.c | 14 +++++++-------
>   1 file changed, 7 insertions(+), 7 deletions(-)
> 
> diff --git a/drivers/firmware/stratix10-svc.c b/drivers/firmware/stratix10-svc.c
> index b91f68d9ae98..59d9f588d9ee 100644
> --- a/drivers/firmware/stratix10-svc.c
> +++ b/drivers/firmware/stratix10-svc.c
> @@ -1316,7 +1316,7 @@ int stratix10_svc_async_send(struct stratix10_svc_chan *chan, void *msg,
>   		dev_dbg(ctrl->dev,
>   			"Async message sent with transaction_id 0x%02x\n",
>   			handle->transaction_id);
> -			*handler = handle;
> +		*handler = handle;
>   		return 0;
>   	case INTEL_SIP_SMC_STATUS_BUSY:
>   		dev_warn(ctrl->dev, "Mailbox is busy, try after some time\n");
> @@ -1701,12 +1701,12 @@ int stratix10_svc_send(struct stratix10_svc_chan *chan, void *msg)
>   			kthread_run_on_cpu(svc_normal_to_secure_thread,
>   					   (void *)chan->ctrl,
>   					   cpu, "svc_smc_hvc_thread");
> -			if (IS_ERR(chan->ctrl->task)) {
> -				dev_err(chan->ctrl->dev,
> -					"failed to create svc_smc_hvc_thread\n");
> -				kfree(p_data);
> -				return -EINVAL;
> -			}
> +		if (IS_ERR(chan->ctrl->task)) {
> +			dev_err(chan->ctrl->dev,
> +				"failed to create svc_smc_hvc_thread\n");
> +			kfree(p_data);
> +			return -EINVAL;
> +		}
>   	}
>   
>   	pr_debug("%s: sent P-va=%p, P-com=%x, P-size=%u\n", __func__,

Applied!

Thanks,
Dinh