linux-kernel - Re: [PATCH v4 08/10] smb/client: introduce smb2maperror KUnit tests

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202512091143.FGQ64S2k-lkp@intel.com>
Date: Tue, 9 Dec 2025 11:45:31 +0800
From: kernel test robot <lkp@...el.com>
To: chenxiaosong.chenxiaosong@...ux.dev, sfrench@...ba.org,
	smfrench@...il.com, linkinjeon@...nel.org, linkinjeon@...ba.org
Cc: oe-kbuild-all@...ts.linux.dev, linux-cifs@...r.kernel.org,
	linux-kernel@...r.kernel.org, liuzhengyuan@...inos.cn,
	huhai@...inos.cn, liuyun01@...inos.cn,
	ChenXiaoSong <chenxiaosong@...inos.cn>
Subject: Re: [PATCH v4 08/10] smb/client: introduce smb2maperror KUnit tests

Hi,

kernel test robot noticed the following build errors:

[auto build test ERROR on brauner-vfs/vfs.all]
[also build test ERROR on linus/master v6.18]
[cannot apply to cifs/for-next next-20251208]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/chenxiaosong-chenxiaosong-linux-dev/smb-client-reduce-loop-count-in-map_smb2_to_linux_error-by-half/20251206-232731
base:   https://git.kernel.org/pub/scm/linux/kernel/git/vfs/vfs.git vfs.all
patch link:    https://lore.kernel.org/r/20251206151826.2932970-9-chenxiaosong.chenxiaosong%40linux.dev
patch subject: [PATCH v4 08/10] smb/client: introduce smb2maperror KUnit tests
config: i386-randconfig-063-20251208 (https://download.01.org/0day-ci/archive/20251209/202512091143.FGQ64S2k-lkp@intel.com/config)
compiler: gcc-14 (Debian 14.2.0-19) 14.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20251209/202512091143.FGQ64S2k-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202512091143.FGQ64S2k-lkp@intel.com/

All errors (new ones prefixed by >>):

   ld: fs/smb/client/smb2maperror.o: in function `test_cmp_map':
>> fs/smb/client/smb2maperror_test.c:40:(.text+0x1d4): undefined reference to `kunit_binary_str_assert_format'
>> ld: fs/smb/client/smb2maperror_test.c:40:(.text+0x20c): undefined reference to `__kunit_do_failed_assertion'
>> ld: fs/smb/client/smb2maperror_test.c:39:(.text+0x245): undefined reference to `kunit_binary_assert_format'
   ld: fs/smb/client/smb2maperror_test.c:39:(.text+0x263): undefined reference to `__kunit_do_failed_assertion'
   ld: fs/smb/client/smb2maperror_test.c:38:(.text+0x274): undefined reference to `kunit_binary_assert_format'
   ld: fs/smb/client/smb2maperror_test.c:38:(.text+0x2ba): undefined reference to `__kunit_do_failed_assertion'
>> ld: fs/smb/client/smb2maperror_test.c:37:(.text+0x2da): undefined reference to `kunit_binary_ptr_assert_format'
   ld: fs/smb/client/smb2maperror_test.c:37:(.text+0x314): undefined reference to `__kunit_do_failed_assertion'
   ld: fs/smb/client/smb2maperror.o: in function `maperror_test_check_sort':
>> fs/smb/client/smb2maperror_test.c:28:(.text.unlikely+0x4b): undefined reference to `kunit_binary_assert_format'
>> ld: fs/smb/client/smb2maperror_test.c:28:(.text.unlikely+0x60): undefined reference to `__kunit_do_failed_assertion'


vim +40 fs/smb/client/smb2maperror_test.c

    12	
    13	static void maperror_test_check_sort(struct kunit *test)
    14	{
    15		bool is_sorted = true;
    16		unsigned int i;
    17	
    18		for (i = 1; i < err_map_num; i++) {
    19			if (smb2_error_map_table[i].smb2_status >=
    20			    smb2_error_map_table[i - 1].smb2_status)
    21				continue;
    22	
    23			pr_err("smb2_error_map_table array order is incorrect\n");
    24			is_sorted = false;
    25			break;
    26		}
    27	
  > 28		KUNIT_EXPECT_EQ(test, true, is_sorted);
    29	}
    30	
    31	static void
    32	test_cmp_map(struct kunit *test, struct status_to_posix_error *expect)
    33	{
    34		struct status_to_posix_error *result;
    35	
    36		result = smb2_get_err_map(expect->smb2_status);
  > 37		KUNIT_EXPECT_PTR_NE(test, NULL, result);
    38		KUNIT_EXPECT_EQ(test, expect->smb2_status, result->smb2_status);
  > 39		KUNIT_EXPECT_EQ(test, expect->posix_error, result->posix_error);
  > 40		KUNIT_EXPECT_STREQ(test, expect->status_string, result->status_string);
    41	}
    42	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki