linux-kernel - Re: [PATCH 01/30] smb/client: fix NT_STATUS_NO_DATA

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAH2r5mtQPx3K20bsOrZFHHwQsy4yMGMTYJx1X0vJqXG=dYDwWA@mail.gmail.com>
Date: Mon, 8 Dec 2025 18:29:54 -0600
From: Steve French <smfrench@...il.com>
To: ChenXiaoSong <chenxiaosong@...inos.cn>
Cc: chenxiaosong.chenxiaosong@...ux.dev, linkinjeon@...nel.org, 
	linkinjeon@...ba.org, linux-cifs@...r.kernel.org, 
	linux-kernel@...r.kernel.org, liuzhengyuan@...inos.cn, huhai@...inos.cn, 
	liuyun01@...inos.cn
Subject: Re: [PATCH 01/30] smb/client: fix NT_STATUS_NO_DATA_DETECTED value

These (return code, NT STATIUS code names) are unlikely to change much
so probably would not need to regenerate, although wouldn't hurt to
check every year or so.

On Mon, Dec 8, 2025 at 6:17 PM ChenXiaoSong <chenxiaosong@...inos.cn> wrote:
>
> Hi Steve and Namjae,
>
> Some of these macro values seem to differ from the documentation
> (possibly due to typos or updates in the docs). Should we, like Samba,
> use a script to automatically regenerate these macro definitions on a
> regular basis?
>
> Thanks,
> ChenXiaoSong.
>
> On 12/8/25 2:20 PM, chenxiaosong.chenxiaosong@...ux.dev wrote:
> > From: ChenXiaoSong <chenxiaosong@...inos.cn>
> >
> > This was reported by the KUnit tests in the later patches.
> >
> > See MS-ERREF 2.3.1 STATUS_NO_DATA_DETECTED. Keep it consistent with the
> > value in the documentation.
> >
> > Signed-off-by: ChenXiaoSong <chenxiaosong@...inos.cn>
> > ---
> >   fs/smb/client/nterr.h | 2 +-
> >   1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/fs/smb/client/nterr.h b/fs/smb/client/nterr.h
> > index 180602c22355..4fd79a82c817 100644
> > --- a/fs/smb/client/nterr.h
> > +++ b/fs/smb/client/nterr.h
> > @@ -41,7 +41,7 @@ extern const struct nt_err_code_struct nt_errs[];
> >   #define NT_STATUS_MEDIA_CHANGED    0x8000001c
> >   #define NT_STATUS_END_OF_MEDIA     0x8000001e
> >   #define NT_STATUS_MEDIA_CHECK      0x80000020
> > -#define NT_STATUS_NO_DATA_DETECTED 0x8000001c
> > +#define NT_STATUS_NO_DATA_DETECTED 0x80000022
> >   #define NT_STATUS_STOPPED_ON_SYMLINK 0x8000002d
> >   #define NT_STATUS_DEVICE_REQUIRES_CLEANING 0x80000288
> >   #define NT_STATUS_DEVICE_DOOR_OPEN 0x80000288
>


-- 
Thanks,

Steve