linux-kernel - [PATCH] x86/elf: Fix core dump truncation on CPUs with no extended xfeatures

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20251209072124.3119466-1-yongxin.liu@windriver.com>
Date: Tue,  9 Dec 2025 15:21:24 +0800
From: yongxin.liu@...driver.com
To: x86@...nel.org
Cc: linux-kernel@...r.kernel.org, bp@...en8.de, tglx@...utronix.de,
        mingo@...hat.com, dave.hansen@...ux.intel.com, vigbalas@....com,
        stable@...r.kernel.org
Subject: [PATCH] x86/elf: Fix core dump truncation on CPUs with no extended xfeatures

From: Yongxin Liu <yongxin.liu@...driver.com>

Zero can be a valid value of num_records. For example, on Intel Atom x6425RE,
only x87 and SSE are supported (features 0, 1), and fpu_user_cfg.max_features
is 3. The for_each_extended_xfeature() loop only iterates feature 2, which is
not enabled, so num_records = 0. This is valid and should not cause core dump
failure.

The size check already validates consistency: if num_records = 0, then
en.n_descsz = 0, so the check passes.

Cc: stable@...r.kernel.org
Fixes: ba386777a30b ("x86/elf: Add a new FPU buffer layout info to x86 core files")
Signed-off-by: Yongxin Liu <yongxin.liu@...driver.com>
---
 arch/x86/kernel/fpu/xstate.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/arch/x86/kernel/fpu/xstate.c b/arch/x86/kernel/fpu/xstate.c
index 48113c5193aa..b1dd30eb21a8 100644
--- a/arch/x86/kernel/fpu/xstate.c
+++ b/arch/x86/kernel/fpu/xstate.c
@@ -1984,8 +1984,6 @@ int elf_coredump_extra_notes_write(struct coredump_params *cprm)
 		return 1;
 
 	num_records = dump_xsave_layout_desc(cprm);
-	if (!num_records)
-		return 1;
 
 	/* Total size should be equal to the number of records */
 	if ((sizeof(struct x86_xfeat_component) * num_records) != en.n_descsz)
-- 
2.46.2