linux-kernel - Re: [PATCH v1 1/1] bpf: Mark bpf_stream_vprintk_impl() with _

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAADnVQ+ZRw+B_=4UVKhecHuMS5-Y7gKWx6N=LYEPyRuAFg8qAw@mail.gmail.com>
Date: Tue, 9 Dec 2025 18:14:29 +0900
From: Alexei Starovoitov <alexei.starovoitov@...il.com>
To: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Cc: Alexei Starovoitov <ast@...nel.org>, Kumar Kartikeya Dwivedi <memxor@...il.com>, 
	Puranjay Mohan <puranjay@...nel.org>, bpf <bpf@...r.kernel.org>, 
	LKML <linux-kernel@...r.kernel.org>, Daniel Borkmann <daniel@...earbox.net>, 
	Andrii Nakryiko <andrii@...nel.org>, Martin KaFai Lau <martin.lau@...ux.dev>, 
	Eduard Zingerman <eddyz87@...il.com>, Song Liu <song@...nel.org>, 
	Yonghong Song <yonghong.song@...ux.dev>, John Fastabend <john.fastabend@...il.com>, 
	KP Singh <kpsingh@...nel.org>, Stanislav Fomichev <sdf@...ichev.me>, Hao Luo <haoluo@...gle.com>, 
	Jiri Olsa <jolsa@...nel.org>, Alan Maguire <alan.maguire@...cle.com>, 
	Mirsad Todorovac <mtodorovac69@...oo.com>
Subject: Re: [PATCH v1 1/1] bpf: Mark bpf_stream_vprintk_impl() with
 __printf() attribute

On Tue, Dec 9, 2025 at 12:49 AM Andy Shevchenko
<andriy.shevchenko@...ux.intel.com> wrote:
>
> bpf_stream_vprintk_impl() is using printf() type of format, and compiler
> is not happy about them as is:
>
> kernel/bpf/stream.c:241:9: error: function ‘bpf_stream_vprintk_impl’ might be a candidate for ‘gnu_printf’ format attribute [-Werror=suggest-attribute=format]
>   241 |         ret = bstr_printf(data.buf, MAX_BPRINTF_BUF, fmt__str, data.bin_args);
>       |         ^~~
>
> Fix the compilation errors by adding __printf() attribute.
>
> Fixes: 5ab154f1463a ("bpf: Introduce BPF standard streams")
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
> ---
>  kernel/bpf/stream.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/kernel/bpf/stream.c b/kernel/bpf/stream.c
> index 0b6bc3f30335..4bff72e3c16f 100644
> --- a/kernel/bpf/stream.c
> +++ b/kernel/bpf/stream.c
> @@ -212,6 +212,7 @@ __bpf_kfunc_start_defs();
>   * Avoid using enum bpf_stream_id so that kfunc users don't have to pull in the
>   * enum in headers.
>   */
> +__printf(2, 0)
>  __bpf_kfunc int bpf_stream_vprintk_impl(int stream_id, const char *fmt__str, const void *args,

same issue.
The addition of this attribute doesn't make any difference, since kfunc
protos are autogenerated from BTF and it's not there.

pw-bot: cr