linux-kernel - Re: [PATCH] irqchip/mchp-eic: Fix error code in mchp_eic_domain

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b0c8616b-24ec-4da0-abe7-4514069c1679@tuxon.dev>
Date: Tue, 9 Dec 2025 11:27:57 +0200
From: Claudiu Beznea <claudiu.beznea@...on.dev>
To: Dan Carpenter <dan.carpenter@...aro.org>
Cc: Thomas Gleixner <tglx@...utronix.de>, Marc Zyngier <maz@...nel.org>,
 linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
 kernel-janitors@...r.kernel.org
Subject: Re: [PATCH] irqchip/mchp-eic: Fix error code in
 mchp_eic_domain_alloc()



On 12/9/25 08:54, Dan Carpenter wrote:
> If the irq_domain_translate_twocell() function sets "hwirq" to >=
> MCHP_EIC_NIRQ (2) then it would result in an out of bounds access.
> The code here checks for invalid values, but doesn't set the error
> code.  Return -EINVAL in that case, instead of returning success.
> 
> Fixes: 00fa3461c86d ("irqchip/mchp-eic: Add support for the Microchip EIC")
> Signed-off-by: Dan Carpenter <dan.carpenter@...aro.org>

Reviewed-by: Claudiu Beznea <claudiu.beznea@...on.dev>