linux-kernel - [PATCH 00/13 smb: move duplicate definitions into common header file, part 2

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20251209011020.3270989-1-chenxiaosong.chenxiaosong@linux.dev>
Date: Tue,  9 Dec 2025 09:10:06 +0800
From: chenxiaosong.chenxiaosong@...ux.dev
To: sfrench@...ba.org,
	smfrench@...il.com,
	linkinjeon@...nel.org,
	linkinjeon@...ba.org
Cc: linux-cifs@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	liuzhengyuan@...inos.cn,
	huhai@...inos.cn,
	liuyun01@...inos.cn,
	ChenXiaoSong <chenxiaosong@...inos.cn>
Subject: [PATCH 00/13 smb: move duplicate definitions into common header file, part 2

From: ChenXiaoSong <chenxiaosong@...inos.cn>

I'm currently working on implementing the SMB2 change notify feature in
ksmbd, and noticed several duplicated definitions that exist on both client
and server. Maybe we can clean these up first.

This is a continuous effort to move duplicated definitions in both client
and server into common header files, which makes the code easier to
maintain.

The previous work is here:
https://lore.kernel.org/linux-cifs/20251117112838.473051-1-chenxiaosong.chenxiaosong@linux.dev/

ChenXiaoSong (7):
  smb: add documentation references for smb2 change notify definitions
  smb: move notify completion filter flags into common/smb2pdu.h
  smb: move SMB2 Notify Action Flags into common/smb2pdu.h
  smb: move file_notify_information to common/fscc.h
  smb: move File Attributes definitions into common/fscc.h
  smb: update struct duplicate_extents_to_file_ex
  smb/server: add comment to FileSystemName of
    FileFsAttributeInformation

ZhangGuoDong (6):
  smb: move smb3_fs_vol_info into common/fscc.h
  smb: move some definitions from common/smb2pdu.h into common/fscc.h
  smb/client: remove DeviceType Flags and Device Characteristics
    definitions
  smb: introduce struct create_posix_ctxt_rsp
  smb: introduce struct file_posix_info
  smb: move some SMB1 definitions into common/smb1pdu.h

 fs/smb/client/cifspdu.h    |  67 +-----
 fs/smb/client/inode.c      |  22 +-
 fs/smb/client/readdir.c    |  28 +--
 fs/smb/client/reparse.h    |   4 +-
 fs/smb/client/smb2pdu.c    |   9 +-
 fs/smb/client/smb2pdu.h    |  21 +-
 fs/smb/common/fscc.h       | 419 ++++++++++++++++++++++++++++++++++-
 fs/smb/common/smb1pdu.h    |  59 +++++
 fs/smb/common/smb2pdu.h    | 433 ++-----------------------------------
 fs/smb/common/smbglob.h    |   2 -
 fs/smb/server/oplock.c     |   8 +-
 fs/smb/server/smb2pdu.c    |  91 ++++----
 fs/smb/server/smb2pdu.h    |  27 +--
 fs/smb/server/smb_common.h |   9 +-
 14 files changed, 589 insertions(+), 610 deletions(-)
 create mode 100644 fs/smb/common/smb1pdu.h

-- 
2.43.0